Skip to content

test(dogfood): the inbound-mail pool suite reads its fixture sets from the security catalog - #23159

Merged
marchtian merged 1 commit into
mainfrom
claude/issue-23056-dogfood-mail-pool-catalog
Oct 13, 2026
Merged

marchtian merged 1 commit into
mainfrom
claude/issue-23056-dogfood-mail-pool-catalog

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #15204
Clause-②: no

What fails on main

main's CI run 38337824333 on 287fd6e5d0, the first full battery that contains D (#22900, c8a9783eca), is red on Dogfood Regression Gate (1/3) in one file:

  • packages/qa/dogfood/test/mail-message-pool-read-gate.dogfood.test.ts:111: fixture permission set mail_pool_22870_read seeded: expected undefined to be truthy.

Why

The change

Test only: one file, 7 lines. It is the hunk S8-T (#22962) carries in this file at 008ca32a75, byte for byte (blob adb8b0fa73):

  • import { catalogPermissionSet } from './catalog-permission-set.js'; (the fixture helper on main since T2);
  • grant asserts the set the security catalog serves, await catalogPermissionSet(ql, setName), instead of a sys_permission_set row.

The grant row it writes is unchanged (permission_set: set.name). #22962 keeps the same hunk, which merges as a no-op once main carries this.

Verification

Local, through scripts/pm/os-verify-lock.sh, on the showcase boot the suite runs (bootShowcase), in a worktree whose product source is main at f931e765b7 (built --filter closure of the dogfood package, turbo exit 0). The eight main commits from f931e765b7 to this PR's base 121847a7d5 touch none of packages/qa, packages/plugins, packages/services/service-mailbox, examples, packages/objectql, packages/rest, packages/runtime, packages/core or packages/metadata-protocol.

  • Before (the file as main carries it): red, the CI assertion at the same line: AssertionError: fixture permission set mail_pool_22870_read seeded: expected undefined to be truthy, frame grant test/mail-message-pool-read-gate.dogfood.test.ts:111:67; the suite's 9 tests did not run.
  • After (this hunk): green, the suite's 9 tests pass (the same file set's run: 279 passed; its one red is activity-text-predicate, a 5000 ms timeout under a contended box, untouched here).

The same before/after on a fresh build of this PR's base 121847a7d5 is queued on the shared verify lock; its result goes to the report on #23056.

Gates: the 53 commands node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derives for this file; the results and the --ran reconciliation are in the report on #23056.

skip-changeset: one test file of the private dogfood package; nothing publishes. The relay's pr_create takes no labels, so the label is the seat's.


Generated by Claude Code

…m the security catalog

Since D (#22900) no boot writes a sys_permission_set row for a set declared
through defaultPermissionSets (ADR-0131 D3), so this suite's grant helper,
which asserted the seeded row, failed on main's full battery. It now asserts
the set the security catalog serves by name (catalogPermissionSet, the
fixture helper T2 added); the grant row it writes is unchanged.

Claude-Session: https://claude.ai/code/session_01ADzJtzYTLUfgrRZHxkagkX
Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 02bec6ca86e9f1237a3f82a9efff9cb3a53562ef → packageMentionDocs.

@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 13, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Epic PM session_01Rerax7QTjKMPCUZxQUtPFR (marchtian), 2026-10-13T04:50Z. A read-only check of this PR, plus one label:

Landing stays with the domain:engine lane. Once this is on main, the seat reads the first full battery whose dogfood shards run, for the first next prerelease.


Generated by Claude Code

@marchtian
marchtian marked this pull request as ready for review October 13, 2026 04:54
@marchtian
marchtian enabled auto-merge October 13, 2026 04:54
@marchtian
marchtian added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit b8f226c Oct 13, 2026
45 of 46 checks passed
@marchtian
marchtian deleted the claude/issue-23056-dogfood-mail-pool-catalog branch October 13, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants