Repository navigation
test(dogfood): the inbound-mail pool suite reads its fixture sets from the security catalog - #23159
Merged
Merged
Conversation
…m the security catalog Since D (#22900) no boot writes a sys_permission_set row for a set declared through defaultPermissionSets (ADR-0131 D3), so this suite's grant helper, which asserted the seeded row, failed on main's full battery. It now asserts the set the security catalog serves by name (catalogPermissionSet, the fixture helper T2 added); the grant row it writes is unchanged. Claude-Session: https://claude.ai/code/session_01ADzJtzYTLUfgrRZHxkagkX Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
|
Epic PM
Landing stays with the Generated by Claude Code |
marchtian
approved these changes
Oct 13, 2026
marchtian
marked this pull request as ready for review
October 13, 2026 04:54
marchtian
enabled auto-merge
October 13, 2026 04:54
This was referenced Oct 13, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15204
Clause-②: no
What fails on
mainmain's CI run 38337824333 on287fd6e5d0, the first full battery that contains D (#22900,c8a9783eca), is red on Dogfood Regression Gate (1/3) in one file:packages/qa/dogfood/test/mail-message-pool-read-gate.dogfood.test.ts:111:fixture permission set mail_pool_22870_read seeded: expected undefined to be truthy.Why
granthelper reads the seededsys_permission_setrow of a set declared throughdefaultPermissionSets.07bc34ac05) moved the dogfood fixtures onto the catalog. PR and queue CI do not run the dogfood shards (skills(ci): two-speed CI — fast set on PR and merge-queue runs, full battery hourly on main and before a release, main-red stops the lane, four required contexts plus the guard, timing gates report-only, test budgets not deletions #22998), so neither PR ran this file against the other beforemain.The change
Test only: one file, 7 lines. It is the hunk S8-T (#22962) carries in this file at
008ca32a75, byte for byte (blobadb8b0fa73):import { catalogPermissionSet } from './catalog-permission-set.js';(the fixture helper onmainsince T2);grantasserts the set the security catalog serves,await catalogPermissionSet(ql, setName), instead of asys_permission_setrow.The grant row it writes is unchanged (
permission_set: set.name). #22962 keeps the same hunk, which merges as a no-op oncemaincarries this.Verification
Local, through
scripts/pm/os-verify-lock.sh, on the showcase boot the suite runs (bootShowcase), in a worktree whose product source ismainatf931e765b7(built--filterclosure of the dogfood package, turbo exit 0). The eightmaincommits fromf931e765b7to this PR's base121847a7d5touch none ofpackages/qa,packages/plugins,packages/services/service-mailbox,examples,packages/objectql,packages/rest,packages/runtime,packages/coreorpackages/metadata-protocol.maincarries it): red, the CI assertion at the same line:AssertionError: fixture permission set mail_pool_22870_read seeded: expected undefined to be truthy, framegrant test/mail-message-pool-read-gate.dogfood.test.ts:111:67; the suite's 9 tests did not run.activity-text-predicate, a 5000 ms timeout under a contended box, untouched here).The same before/after on a fresh build of this PR's base
121847a7d5is queued on the shared verify lock; its result goes to the report on #23056.Gates: the 53 commands
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderives for this file; the results and the--ranreconciliation are in the report on #23056.skip-changeset: one test file of the private dogfood package; nothing publishes. The relay'spr_createtakes no labels, so the label is the seat's.Generated by Claude Code