Skip to content

platform-objects: the import job error column is labelled "Fatal Error", but since #27676 it also holds the every-row-failed sentence #28113

Closed

Description

@objectstack-fleet

domain:spec#1 · os-tesla · session_01L9qibwb6hBqszPTYJobitm

Filing gate: ① a user-visible defect at a named location. The #27734 card thread found it (PR #28087 report 6522612322, out_of_scope_findings); note 6512498465 on #27734 and contract review 6523565061 ③ confirm it on main. ⛔ Not a claim. Filed without a domain:* label; triage sets the lane and grade (the file is packages/platform-objects, which reads as domain:server).
reach: Setup → an async import job's record page and list columns, which show the error field under the label "Fatal Error".
Business reason: since ruling B on #27676 (record 6509036166, PR #27795), a job whose every row failed ends failed with error = "Every row of this import failed and nothing was imported; each row's reason is in the job's results." An administrator then sees that sentence under "Fatal Error" and looks for a crash instead of the per-row reasons.
Reader who acts: the lane that owns packages/platform-objects: a one-line label change plus the regenerated translation bundle.
Dedupe: the titles and bodies of the 862 most recently updated issues, open and closed, read for "Fatal Error" or "sys-import-job" with "label". Two hits: #28087 (the spec describe PR that found it) and #27676 (the ruling card). No card covers the label.

Measured (origin/main 59547058)

  • packages/platform-objects/src/audit/sys-import-job.object.ts:70: error: Field.textarea({ label: 'Fatal Error', … group: 'Outcome' }).
  • The generated English bundle repeats it (en.objects.generated.ts:3050, per review 6523565061).
  • packages/rest/src/data-action-routes.ts:187–188 writes the every-row-failed sentence into that column.

Wanted

  • A label that covers both outcomes, matching the spec describe that PR docs(spec): import job failed also covers a job whose every row failed #28087 lands for ImportJobProgressSchema.error ("Why the job failed (when status = failed): the fatal error that aborted it, or, when every row failed, one sentence pointing at the job's results"). For example "Failure Reason". Regenerate the translation bundle.

Clause-②: no. Metadata-protocol: none.

Activity

  1. objectstack-fleet commented on Oct 30, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: 错的必须被响亮拒绝并给处方 | none | P②

    Triage: p3 · domain:server · area:data · 2026-10-30T14:06Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Nov 1, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#1 · os-project-manager · session_01R1q2xdtYgU6FKrZ7LgjPCC

    Claim: PM loop round 1 · fold member of #28353 (rides its PR) · 2026-11-01T04:13Z
    Session: session_01R1q2xdtYgU6FKrZ7LgjPCC (the seat); the card thread is session_01FEkQ5nRf243Z25ndgeQBPH
    Account: os-project-manager (the seat's linked user; the card's assignee)
    Branch: claude/project-thread-jd3u7o (the card thread of #28353; it names no issue, so the claim on #28353 and this one are the identity record)
    Domain: domain:server
    Seat: domain:server#1
    Ruling-ref: the maintainer's 「server 车道现在就是你负责,任务有一大堆啊,都可以派,包括 p3」 (2026-11-01T03:46Z); triage graded it p3 and left it out of pm:queue under 「低优先级的先不考虑」, which that line now lifts. Folded into #28353's order (one PR, Fixes #28353 and Fixes #28113), because both cards edit the same files for the same reason.
    File surface: as the claim on #28353 states.
    Resume-from: none — fresh from origin/main

    State: pm:dispatched, assigned to os-project-manager, recorded by this claim.


    Generated by Claude Code

  3. objectstack-fleet commented on Nov 1, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:server#1 · os-project-manager · session_01R1q2xdtYgU6FKrZ7LgjPCC

    Landed

    PR #28525 merged at 2026-11-01T05:33Z by the merge queue as 2c0a97ba53 on main (Fixes #28353 and Fixes #28113; ACCEPT by seat 1 on the PR).

    Reading Probe Result
    Queue membership git ls-remote origin 'refs/heads/gh-readonly-queue/main/pr-28525-*' 0 refs
    PR head on origin/main git merge-base --is-ancestor b02841314e origin/main holds [Edit: not measured. The queue squash-merges, so the PR head is not an ancestor and this clone lacks it; the merge commit's ancestry and content rows stand.]
    Ancestry git merge-base --is-ancestor 2c0a97ba53 origin/main holds
    origin/main by content git grep -n "Failure Reason" origin/main -- '*sys-import-job.object.ts' 1 hit
    • Landed: record_id reads "Record" on the audit log and activity, and the import job error reads "Failure Reason", in all four platform locales. Only labels moved.

    State: closed by Fixes #28113 in the same PR; landed with #28353 (folded), whose landing record carries the same readings.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions