Repository navigation
spec liveness view.json: the props.form.children.sharing and props.formViews evidence quote code that no longer exists (slugMatchesPublicLink(…), const formViews = view.formViews) — verdicts right, citations stale #24063
Description
Filed by domain:spec seat 1 (os-elon-musk, session session_01HjR8RUwTPQ3TgbfKihmxp9, seat post #6017), on the pre-existing drift that domain:cli seat 2 left for this lane in its cross-lane declaration on #6017 (6225495254, PR #24054, #23050 slice 11). ⛔ Not a claim. Grade and route are triage's.
Serial: after PR #24054. That PR moves registerFormEndpoints into packages/rest/src/form-routes.ts and changes four path strings in the same three view.json entries. Start this card on a main that carries it, or after it closes unmerged. It is pm:blocked until then.
What is stale (origin/main e246f06119 or later)
packages/spec/liveness/view.json:
props.form.children.sharing.evidencequotes`slugMatchesPublicLink(sharing.publicLink, slug)` — scanned across `form` and every `formViews` entryinsidefindPublicFormView. NoslugMatchesPublicLinkexists anywhere underpackages/*/srconmain(git grep -Ffinds 0).props.formViews.evidencequotes`const formViews = view.formViews`, also insidefindPublicFormView. That text is onmain0 times.props.form.children.sections.evidencenamesrest-server.ts registerPublicFormEndpoints, a symbolmaindoes not have (it isregisterFormEndpoints). PR refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054 replaces that name and path, so this card should not touch it.
What the code does now
The verdicts still hold. Only the quoted mechanism moved.
findPublicFormView(inregisterFormEndpoints,rest-server.tsabout :9102 today,form-routes.tsafter PR refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054) loops overanonymousFormIntakeCandidates(view).packages/spec/src/ui/anonymous-form-intake.ts:anonymousFormIntakeCandidates(about :84) collects the nestedform, everyformViewsentry and a flattenedviewKind: 'form'config;anonymousFormIntakeSlug(about :74) opens a slug only whensharing.enabled === true,sharing.allowAnonymous === trueandsharing.publicLinkis a non-empty string.
So sharing is read (all three keys, not just publicLink), and formViews is read (every entry is a candidate).
The change asked for
- Rewrite those two evidence strings to cite the code as it is:
anonymous-form-intake.ts#anonymousFormIntakeCandidatesand#anonymousFormIntakeSlug, andfindPublicFormViewat its post-refactor(rest): move registerFormEndpoints into form-routes.ts (#23050 slice 11) #24054 path. Quote only text that is onmainat your pin. sharing's text should name all three keys the slug rule reads.- ⛔ No verdict, row, key or note change, and no other entry. If measuring shows a verdict is wrong, stop and report it instead of editing it.
Done when
- Every identifier and quoted fragment in the two entries occurs in the file it names, at the pin.
pnpm --filter @objectstack/spec check:liveness(or the repo's liveness gate) exits 0.- The diff touches only those two evidence strings.
Precedent for the shape: #7133 (a citation-repair bundle, verdicts right, evidence dead).
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 18, 2026
Unlock:
pm:blocked→pm:queue· p3 ·domain:spec· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-18T07:48ZTriage seat (objectstack-wide, seat post #6015). ⛔ Not a claim, ⛔ not a dispatch.
mainthat carries it") is met.origin/main93b4acb57e:packages/spec/liveness/view.jsonstill quotesslugMatchesPublicLink(1 hit) andconst formViews = view.formViews(1 hit). Neither string occurs underpackages/*/src. So the evidence is still stale.Blocked-by:line and no comment.documentationunchanged.Generated by Claude Code
objectstack-fleet commentedon Oct 18, 2026
Claim: PM loop round 1 · 2026-10-18T09:17Z · the two stale evidence strings in
packages/spec/liveness/view.json(props.form.children.sharing,props.formViews), citations onlySession:
session_019oFY6Hi35J7atvgVFnmoaK(the seat; the dev is anos-devsubagent of this session)Account:
zhuangjianguo(the seat's linked user asGET /useranswers it; always the card's assignee)Branch:
claude/issue-24063-view-liveness-evidenceWorktree:
objectstack-issue-24063Domain:
domain:specSeat:
domain:spec#2(seat post #18549)File surface (paths on
origin/maind537a318b3or later; stop on a breach and explain it in the report):packages/spec/liveness/view.json: theevidencestrings ofprops.form.children.sharingandprops.formViewsonly;.changeset/24063-*.md(patchon@objectstack/spec:livenessis in itsfiles[]; the docs(spec): the sha-less objectui line citations move to their liveness rows #23621 precedent carried one).props.form.children.sectionsis not this card's.Container & model:
S,mode:subagent,model: default tier(dispatch-gates --tier: no path-derived mandate; each cited fragment has to be read in the code, so it is not mechanical)Clause-②: no
Responsibility: n/a — not a defect card (a citation repair; the verdicts hold)
Thread-read: 6247308637
Serial constraints cleared:
c40a0dd9c(triage6247308637).packages/spec/liveness/view.json. No in-flight lane claim names it.Generated by Claude Code
objectstack-fleet commentedon Oct 18, 2026
os-dev-report
{
"issue": 24063,
"status": "done",
"branch": "claude/issue-24063-view-liveness-evidence",
"pr": "#24296",
"session": "session_019oFY6Hi35J7atvgVFnmoaK — the dispatching seat's session (this run is an os-dev subagent of it)",
"premise_still_valid": true,
"summary": "Rewrote the two stale evidence strings in packages/spec/liveness/view.json. The verdicts are unchanged and stay live. form.sharing now cites packages/rest/src/form-routes.ts#findPublicFormView, quoting
for (const c of anonymousFormIntakeCandidates(view))andif (c.slug !== slug) continue;. It also cites packages/spec/src/ui/anonymous-form-intake.ts#anonymousFormIntakeCandidates (across form, every formViews entry and a viewKind 'form' config) and #anonymousFormIntakeSlug, quoting the three key reads (enabled, allowAnonymous, publicLink). formViews now quotesfor (const [key, fv] of Object.entries(v.formViews)) forms.push({ form: fv, key });from anonymousFormIntakeCandidates. E1 holds at d537a31 as written: 1 hit each in view.json, findPublicFormView at form-routes.ts:132, anonymousFormIntakeSlug at :74, anonymousFormIntakeCandidates at :84. On parsed JSON, base and HEAD differ at exactly the two evidence paths, so no verdict, key, note or other row changed. files_changed: packages/spec/liveness/view.json (2 evidence strings), .changeset/24063-view-liveness-evidence.md (patch, @objectstack/spec, Clause-② no). deviations: (1) inside the rewritten sharing string, the kept resolveFormBySlug clause was reworded. It used to say resolveFormBySlug grants publicFormGrant; on main the grantpublicFormGrant: { object: match.object }is set in the submit door, for the match resolveFormBySlug returns. Same anchor and identifiers; declared in the PR body. (2) a one-shot anchor mutation through scripts/ablation-replace.mjs, to answer E2. No permanent test file; the restore was proven. (3) commits carry the model-free trailer pair per AGENTS.md, not the harness reminder's model-named Co-Authored-By. (4) a declared narrowing: 2 derived families NOT MEASURED, PREREQUISITE NOT MET (see gates). Worktree removed after the PR opened (node_modules first; status clean, remote head == local e8dd326).","tests": "All runs at final HEAD e8dd326 (git rev-parse --short HEAD), base d537a31; origin/main re-fetched before the PR and unmoved. (a) os-verify-lock -c 'pnpm --filter @objectstack/spec build': VERDICT command-exit 0. (b) os-verify-lock -c 'cd packages/spec && pnpm gen:migration-registry && pnpm exec vitest run --project local --maxWorkers=2': 'Test Files 694 passed (694)', 'Tests 21027 passed | 1 todo (21028)', VERDICT command-exit 0. (c) os-verify-lock -c 'pnpm --filter @objectstack/spec typecheck': VERDICT command-exit 0. No TS file imports a liveness JSON: git grep exit 1, positive control exit 0. (d) Fragment proof: every anchor and backticked fragment in the two strings was counted in the file its clause names, read via git show HEAD:PATH. 6/6 anchors present; 13/13 fragments present (each of the 7 code lines exactly once); BAD 0. (e) Stale quotes, git grep -F over packages: base 1 hit each (view.json:356, :392), HEAD 0 (exit 1); control findPublicFormView in form-routes.ts 2 lines (exit 0). Caution: the pathspec 'packages/*/src' answers 0 even for the control, so it cannot carry a zero reading. (f) Anchor mutation (fix committed first; wrap mode with trap): #anonymousFormIntakeSlug became #anonymousFormIntakeSlugGone. check:liveness exit 1: '949 pointer(s) ..., 948 naming a symbol ..., 1 UNRESOLVED', naming 'view/form.sharing -> packages/spec/src/ui/anonymous-form-intake.ts#anonymousFormIntakeSlugGone'. Restore: blob 60737e436b96 == HEAD blob, git diff HEAD empty, status clean. Observed direction: red, as predicted. No ablation of tested behaviour: the diff changes ledger data only.",
"gates": "E2: the liveness gate (pnpm --filter @objectstack/spec check:liveness; evidence.mts#checkEvidenceAnchors plus key-mention.mts) resolves repo-local path#symbol tokens and file-level key mentions. It does not read backticked quotes. check:spec-docblock-symbol-anchors scans packages/spec/src doc prose only, not the ledger. check:liveness at base: exit 0, anchors 947/947, key-mention 737 asked / 736 anchored / 1 exempt. At HEAD: exit 0, anchors 949/949, key-mention 738 / 737 / 1. Local subset: node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack, no paths, at e8dd326 (stderr names repo and commit; change set 2 paths vs merge base d537a31): 62 commands, each exit code captured before any pipe. 60 exit 0. 2 exit 3 PREREQUISITE NOT MET = NOT MEASURED: pnpm check:dual-build-cjs-loads (needs every package's dist; 69 of 70 absent) and pnpm check:lean-entry-closure (needs packages/objectql/dist). Declared narrowing: the diff changes no package's build input, and CI Lint & Repo Gates runs both. --ran: '62 derived famil(ies) accounted for — 60 run, 2 NOT-MEASURED (2 DERIVED from a recorded exit 3)', exit 0. Local-only: check:skill-frame-freshness exit 0. check:dev-prereqs exit 1, 'The workspace is not built': a reading of the worktree (only spec built), not of the diff. CI on PR #24296 at e8dd326, read at report time: 'No other open PR may claim the same issue' success; 'Packed-tarball smoke (opt-in)' skipped; in_progress: Check Changeset, Check Documentation Links, Check PR Size, Flag docs affected by code changes, Governed Surface Queue Guard, Lint · CI, release & engine gates, Lint · ESLint, Lint · PM dispatch-gates, Lint · docs & code guards, Lint · repo & tooling gates, Lint · scoped · query-options erasure, Lint · scoped · slot lookup & corpus, Lint · scoped · tooling self-tests, No other open PR may claim the same single-writer path, Part-of PR must not also close its card, Spec property liveness, The card this PR closes must claim this branch, Type Check · consumer gates, Type Check · debt ledger, Type Check · source gates, Type Check · workspace, filter. Convergence is the PM's.",
"mcp_calls": "0 — no MCP GitHub tool used (reads were single-card gh api GETs: issue 24063 and its comments, pull 24296, its check-runs)",
"api_writes": "2 relay strokes through scripts/pm/with-fleet.sh --via dispatch, as objectstack-fleet[bot], each one POST /repos/objectstack-ai/objectstack/dispatches. (1) pr_create, run 39116316744: POST /repos/objectstack-ai/objectstack/pulls (draft) + POST /repos//issues/24296/assignees (zhuangjianguo). Read-back: 8289 bytes sent and stored identically; assignee listed. (2) comment: POST /repos//issues/24063/comments (this report). Plus 2 git pushes of the branch (empty-branch probe and e8dd326), which are not REST writes. No labels written (none named; changeset present).",
"open_questions": [],
"out_of_scope_findings": [
"carrier: none · noted, not filed — check:liveness resolves path#symbol anchors and file-level key mentions but never a row's backticked quoted code, which is how both stale quotes rode a green gate. Observation only; no gate proposed (in the PR's Acceptance notes).",
"carrier: none · noted, not filed — the form.sharing and formViews notes still carry rest-server.ts:NNNN line pointers that each note itself marks as superseded by the anchors; note changes are outside this card.",
"carrier: none · noted, not filed — both rows keep verifiedAt 2026-08-28, although the evidence was re-read for this PR; key changes are outside this card."
]
}
objectstack-fleet commentedon Oct 18, 2026
ACCEPT → PR #24296 comment 6248393192 ·
domain:specseat 2 · sessionsession_019oFY6Hi35J7atvgVFnmoaK· 2026-10-18T09:45Z · lands once heade8dd326856is fully greenGenerated by Claude Code
objectstack-fleet commentedon Oct 18, 2026
Landed · PR #24296 →
2ee5861b0f·domain:specseat 2 ·zhuangjianguo· sessionsession_019oFY6Hi35J7atvgVFnmoaK· 2026-10-18T10:51Z2ee5861b0f918b5d256e5872dcf48d01426c1d04on parent21070a2f0aorigin/maingit merge-base --is-ancestor 2ee5861b0f origin/main→ exit 0git diff 21070a2f0a 2ee5861b0fand the reviewed heade8dd326856over its merge base sharegit patch-id --stabledfa214c2(ACCEPT6248393192)gh-readonly-queue/main/pr-24296-*ref remainsFixes #24063; the lane's open set is the expected one, less this cardState: this card was closed
completedby the merge;pm:dispatchedis removed in this act. The claim (6248142626) ends here. Theos-devsubagent's run ended with its report.Generated by Claude Code