mpfdtype: Fix routing issues and add tests. - #263
Open
rabbott999 wants to merge 1 commit into
Open
rabbott999 wants to merge 1 commit into
rabbott999 wants to merge 1 commit into
Conversation
These are all issues with where different ufuncs are routed, and adds a test for unary ufuncs which would've caught the issue. The issues are: - The implementations of np.square and np.sqrt are swapped (ironically this doesn't show up in the README example since it uses arr**2 + np.sqrt(a)) - np.arctan calls mpf_tan instead of mpfr_atan - np.exp2 calls exp instead of exp2 - Functions are implemented for np.sin, np.cos, and np.tan, but they are not registered in umath.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all issues with where different ufuncs are routed, and adds a test for unary ufuncs which would've caught the issue.
The issues are:
arr**2 + np.sqrt(a))For full disclosure, I found these issues while pointing an LLM at the codebase, but the changes and write-up are my own.