Skip to content

chore: use simple-icons for the tangled icon - #3321

Merged
trueberryless merged 1 commit into
npmx-dev:mainfrom
Tobbe:tobbe-chore-tangled-simple-icons
Oct 11, 2026
Merged

trueberryless merged 1 commit into
npmx-dev:mainfrom
Tobbe:tobbe-chore-tangled-simple-icons

Conversation

@Tobbe

@Tobbe Tobbe commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Simple Icons now includes Tangled, so use that instead of the custom copy of the logo. Also adds the icon to the providers table in the docs.

🔗 Linked issue

N/A

🧭 Context

Using the official simple-icons version of the Tangled logo

📚 Description

Instead of using a custom/vendored version of the Tangled logo, this PR switches over to the Tangled icon that's included in the simple-icons icon set. Most other forges already use an icon from the existing set, so this brings Tangled in line with those.

Here's the icon on the simpleicons web page https://simpleicons.org/?q=tangled

Simple Icons now includes Tangled, so use that instead of the custom
copy of the logo. Also adds the icon to the providers table in the docs.
@agentscanapp

agentscanapp Bot commented Oct 11, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @Tobbe.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs.npmx.dev Ready Ready Preview Oct 11, 2026 3:00pm UTC
npmx.dev Ready Ready Preview Oct 11, 2026 3:00pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
npmx-lunaria Ignored Ignored Oct 11, 2026 3:00pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f83b549-1859-488f-8a55-23db1aa4eba3

📥 Commits

Reviewing files that changed from the base of the PR and between 809f5c4 and ae57dfc.


📒 Files selected for processing (4)
  • app/components/OgImage/Package.takumi.vue
  • app/composables/useProviderIcon.ts
  • assets/media/custom-icons.json
  • docs/content/2.guide/1.features.md

💤 Files with no reviewable changes (1)
  • assets/media/custom-icons.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Updates
    • Tangled is now displayed with its Simple Icons icon across the app and supported providers guide.

Walkthrough

The Tangled provider icon now uses the Simple Icons icon in the application and guide. The custom Tangled icon entry was removed.

Changes

Tangled icon update

Layer / File(s) Summary
Update Tangled icon references
app/composables/useProviderIcon.ts, app/components/OgImage/Package.takumi.vue, assets/media/custom-icons.json, docs/content/2.guide/1.features.md
The provider icon mapping, package image, and guide now use the Simple Icons Tangled icon. The custom Tangled icon entry was removed.

Suggested reviewers: wilcosp


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ae57d

The Tangled icon update appears ready to merge after normal checks.

Pre-merge checks | Passed 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: replacing the custom Tangled icon with the Simple Icons version.
Description check Passed The description directly explains the icon replacement and the related documentation update. It is relevant to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@trueberryless trueberryless left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Thanks for the PR 🚀

@trueberryless
trueberryless added this pull request to the merge queue Oct 11, 2026
Merged via the queue into npmx-dev:main with commit 89b9422 Oct 11, 2026
25 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 11, 2026
@github-actions github-actions Bot mentioned this pull request Oct 12, 2026

This branch was successfully deployed

2 active deployments
Preview – npmx.dev — ae57dfcb Deployed Oct 11, 2026 by vercel[bot]
Preview – docs.npmx.dev — ae57dfcb Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants