Repository navigation
fix(docs): preserve multiline property documentation - #3290
aniruddhaadak80 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @aniruddhaadak80. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughClass and interface member descriptions now use ChangesMember documentation rendering
Suggested reviewers: Priority: ⬇️ Low Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The change preserves multiline property documentation, and no actionable merge risk is established. It is mergeable after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Class and interface member documentation can now contain formatted links and HTML generated from Markdown. The change reuses existing escaping and link handling, and no new endpoint was identified. The remaining risk is limited but not fully established as absent. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@aniruddhaadak80 |
Linked issue
Closes #2843
Context
The docs renderer discarded every line after the first line of class and interface member JSDoc. Property descriptions containing lists or wrapped text were therefore incomplete in generated package documentation.
Description
renderMarkdownrenderer so line breaks, inline code, and JSDoc links are preserved safely.Testing
I did not run commands locally because this contribution was made through GitHub APIs without a local checkout. The repository CI runs these exact commands:
pnpm vp run lintpnpm vp run test:typespnpm vp test --project unit --coverage --reporter=default --reporter=junit --outputFile=test-report.junit.xmlpnpm vp run build:testpnpm vp run test:browser:prebuiltThe new regression is a server-side unit test with a synthetic Deno doc node; no live package or browser fixture is required. I could not capture browser screenshots in the API-only workflow.