Skip to content

build: warn on incompatible quic configure flags - #66754

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:shared-quic-deps
Open

build: warn on incompatible quic configure flags#66754
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:shared-quic-deps

Conversation

@aduh95

@aduh95 aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

We emit similar errors for other configure flags, QUIC is the odd one out where errors are silently swallowed. Those should be turned into errors, but that can be a follow up that we won't backport, while this one should be safe to backport.

@aduh95
build: warn on incompatible quic configure flags
04f8ebb 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Oct 15, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 15, 2026
@aduh95
aduh95 requested a review from jasnell October 15, 2026 14:47
legendecas
legendecas reviewed Oct 16, 2026
View reviewed changes
Comment thread configure.py
legendecas
legendecas reviewed Oct 16, 2026
View reviewed changes
Comment thread configure.py Outdated
@aduh95 @legendecas
Apply suggestion from @legendecas
c33204d 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78444/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @legendecas