Repository navigation
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
panva
approved these changes
Oct 15, 2026
pimterry
approved these changes
Oct 15, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66752 +/- ##
==========================================
- Coverage 90.49% 90.48% -0.01%
==========================================
Files 797 797
Lines 277494 277495 +1
Branches 53321 53331 +10
==========================================
- Hits 251115 251097 -18
+ Misses 16802 16797 -5
- Partials 9577 9601 +24
🚀 New features to boost your workflow:
|
4 tasks done
dsanders11
added a commit
to electron/electron
that referenced
this pull request
Oct 16, 2026
* chore: adopt nodejs/node#66752 in BoringSSL node patch Rework fix_handle_boringssl_and_openssl_incompatibilities.patch to carry the OPENSSL_SIZE_T changes from nodejs/node#66752 verbatim instead of Electron's own size_t edits, so the patch drops out cleanly once Electron updates to a Node.js version that includes it. Also drop the `#if 0` guards in src/node_metadata.h and src/node_options.h, restoring upstream's `#if HAVE_OPENSSL`. BoringSSL provides the OpenSSL headers they include and the quic guard keeps openssl/quic.h out, so the guards are no longer needed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * fix: add BoringSSL include path to node snapshot targets With the `#if 0` guards gone, src/node_options.h and src/node_metadata.h include <openssl/opensslv.h> and <openssl/crypto.h> again whenever HAVE_OPENSSL is set. The :node_snapshot and :node_snapshot_stub source sets get HAVE_OPENSSL=1 from :node_internal_config but did not depend on //third_party/boringssl, so they had no BoringSSL include path and the Windows build failed with "'openssl/opensslv.h' file not found" when compiling node_snapshot.cc. Depend on //third_party/boringssl from both targets when node_use_openssl is set, so they see the same headers as libnode. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * chore: use $node_openssl_path for node snapshot OpenSSL dep Depend on "$node_openssl_path" rather than hard-coding //third_party/boringssl in the :node_snapshot and :node_snapshot_stub targets, matching how upstream's unofficial.gni references OpenSSL. Electron sets node_openssl_path = "//third_party/boringssl" in build/args/all.gn, so the resolved dependency is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv --------- Co-authored-by: Claude <noreply@anthropic.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 16, 2026
chore: rework BoringSSL with Node.js incompatibilities patch (#55037) * chore: adopt nodejs/node#66752 in BoringSSL node patch Rework fix_handle_boringssl_and_openssl_incompatibilities.patch to carry the OPENSSL_SIZE_T changes from nodejs/node#66752 verbatim instead of Electron's own size_t edits, so the patch drops out cleanly once Electron updates to a Node.js version that includes it. Also drop the `#if 0` guards in src/node_metadata.h and src/node_options.h, restoring upstream's `#if HAVE_OPENSSL`. BoringSSL provides the OpenSSL headers they include and the quic guard keeps openssl/quic.h out, so the guards are no longer needed. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * fix: add BoringSSL include path to node snapshot targets With the `#if 0` guards gone, src/node_options.h and src/node_metadata.h include <openssl/opensslv.h> and <openssl/crypto.h> again whenever HAVE_OPENSSL is set. The :node_snapshot and :node_snapshot_stub source sets get HAVE_OPENSSL=1 from :node_internal_config but did not depend on //third_party/boringssl, so they had no BoringSSL include path and the Windows build failed with "'openssl/opensslv.h' file not found" when compiling node_snapshot.cc. Depend on //third_party/boringssl from both targets when node_use_openssl is set, so they see the same headers as libnode. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * chore: use $node_openssl_path for node snapshot OpenSSL dep Depend on "$node_openssl_path" rather than hard-coding //third_party/boringssl in the :node_snapshot and :node_snapshot_stub targets, matching how upstream's unofficial.gni references OpenSSL. Electron sets node_openssl_path = "//third_party/boringssl" in build/args/all.gn, so the resolved dependency is unchanged. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv --------- (cherry picked from commit deec352) Claude-Session: https://claude.ai/code/session_01FEtfbdwkKabsmYWAF8Sqsw Co-authored-by: Claude <noreply@anthropic.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 16, 2026
chore: rework BoringSSL with Node.js incompatibilities patch (#55037) * chore: adopt nodejs/node#66752 in BoringSSL node patch Rework fix_handle_boringssl_and_openssl_incompatibilities.patch to carry the OPENSSL_SIZE_T changes from nodejs/node#66752 verbatim instead of Electron's own size_t edits, so the patch drops out cleanly once Electron updates to a Node.js version that includes it. Also drop the `#if 0` guards in src/node_metadata.h and src/node_options.h, restoring upstream's `#if HAVE_OPENSSL`. BoringSSL provides the OpenSSL headers they include and the quic guard keeps openssl/quic.h out, so the guards are no longer needed. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * fix: add BoringSSL include path to node snapshot targets With the `#if 0` guards gone, src/node_options.h and src/node_metadata.h include <openssl/opensslv.h> and <openssl/crypto.h> again whenever HAVE_OPENSSL is set. The :node_snapshot and :node_snapshot_stub source sets get HAVE_OPENSSL=1 from :node_internal_config but did not depend on //third_party/boringssl, so they had no BoringSSL include path and the Windows build failed with "'openssl/opensslv.h' file not found" when compiling node_snapshot.cc. Depend on //third_party/boringssl from both targets when node_use_openssl is set, so they see the same headers as libnode. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * chore: use $node_openssl_path for node snapshot OpenSSL dep Depend on "$node_openssl_path" rather than hard-coding //third_party/boringssl in the :node_snapshot and :node_snapshot_stub targets, matching how upstream's unofficial.gni references OpenSSL. Electron sets node_openssl_path = "//third_party/boringssl" in build/args/all.gn, so the resolved dependency is unchanged. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv --------- (cherry picked from commit deec352) Claude-Session: https://claude.ai/code/session_01FEtfbdwkKabsmYWAF8Sqsw Co-authored-by: Claude <noreply@anthropic.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
Oct 16, 2026
chore: rework BoringSSL with Node.js incompatibilities patch (#55037) * chore: adopt nodejs/node#66752 in BoringSSL node patch Rework fix_handle_boringssl_and_openssl_incompatibilities.patch to carry the OPENSSL_SIZE_T changes from nodejs/node#66752 verbatim instead of Electron's own size_t edits, so the patch drops out cleanly once Electron updates to a Node.js version that includes it. Also drop the `#if 0` guards in src/node_metadata.h and src/node_options.h, restoring upstream's `#if HAVE_OPENSSL`. BoringSSL provides the OpenSSL headers they include and the quic guard keeps openssl/quic.h out, so the guards are no longer needed. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * fix: add BoringSSL include path to node snapshot targets With the `#if 0` guards gone, src/node_options.h and src/node_metadata.h include <openssl/opensslv.h> and <openssl/crypto.h> again whenever HAVE_OPENSSL is set. The :node_snapshot and :node_snapshot_stub source sets get HAVE_OPENSSL=1 from :node_internal_config but did not depend on //third_party/boringssl, so they had no BoringSSL include path and the Windows build failed with "'openssl/opensslv.h' file not found" when compiling node_snapshot.cc. Depend on //third_party/boringssl from both targets when node_use_openssl is set, so they see the same headers as libnode. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv * chore: use $node_openssl_path for node snapshot OpenSSL dep Depend on "$node_openssl_path" rather than hard-coding //third_party/boringssl in the :node_snapshot and :node_snapshot_stub targets, matching how upstream's unofficial.gni references OpenSSL. Electron sets node_openssl_path = "//third_party/boringssl" in build/args/all.gn, so the resolved dependency is unchanged. Claude-Session: https://claude.ai/code/session_01XoTevKUU5Yqx5KULydnHjv --------- (cherry picked from commit deec352) Claude-Session: https://claude.ai/code/session_01FEtfbdwkKabsmYWAF8Sqsw Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following warnings when building against boringssl: