Skip to content

quic: remove obsolete setOutbound() - #66646

Open
efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:quic/remove-setOutbound
Open

efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:quic/remove-setOutbound

Conversation

@efekrskl

Copy link
Copy Markdown
Member

QuicStream.setOutbound() is an undocumented, untested predecessor to setBody(). It's not used anywhere in the codebase, and bypasses the enforced mutual exclusion with stream.writer.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels Oct 10, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrskl force-pushed the quic/remove-setOutbound branch from 9d5a2b6 to 2c6c2d5 Compare October 10, 2026 17:29
@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.45%. Comparing base (38a5f10) to head (2c6c2d5).
⚠️ Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66646      +/-   ##
==========================================
- Coverage   90.45%   90.45%   -0.01%     
==========================================
  Files         791      791              
  Lines      276816   276797      -19     
  Branches    53197    53187      -10     
==========================================
- Hits       250403   250373      -30     
- Misses      16822    16834      +12     
+ Partials     9591     9590       -1     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <ø> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 15, 2026
@pimterry

Copy link
Copy Markdown
Member

Restarting CI fresh, as I think the previous run is going to stay stuck failing due to #66703.

@pimterry pimterry added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 15, 2026
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 15, 2026
@github-actions

This comment was marked as outdated.

@pimterry pimterry removed the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label Oct 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@pimterry pimterry moved this to Bug in QUIC Team Oct 15, 2026
@pimterry pimterry moved this from Bug to Ready to Land in QUIC Team Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

Status: Ready to Land

Development

Successfully merging this pull request may close these issues.

4 participants