Skip to content

deps: V8: cherry-pick 8d14d49c4040 - #66627

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-linux-arm-gcc-17
Open

deps: V8: cherry-pick 8d14d49c4040#66627
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-linux-arm-gcc-17

Conversation

@aduh95

@aduh95 aduh95 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Original commit message:

fix compilation with GCC 16 on arm64

Change-Id: I2cbe5f2a68d4a69bac48eea876ff0ed0cb589171
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8500805
Reviewed-by: Joyee Cheung <joyee@igalia.com>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110517}

Refs: v8/v8@8d14d49

@aduh95
deps: V8: cherry-pick 8d14d49c4040
1704830 
Original commit message:

    fix compilation with GCC 16 on arm64

    Change-Id: I2cbe5f2a68d4a69bac48eea876ff0ed0cb589171
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8500805
    Reviewed-by: Joyee Cheung <joyee@igalia.com>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Anton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#110517}

Refs: v8/v8@8d14d49
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 9, 2026
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 9, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78266/

@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7431/

@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7431/

@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7431/

@Renegade334 Renegade334 linked an issue Oct 9, 2026 that may be closed by this pull request
26.0.0 fails to build on NetBSD: missing include #63146
Open
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue PRs queued for automated landing through the Commit Queue. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

26.0.0 fails to build on NetBSD: missing include

5 participants

@aduh95 @nodejs-github-bot @lpinca @richardlau @legendecas