Skip to content

path: avoid building error label per argument in resolve #66616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RafaelGSS wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

path: avoid building error label per argument in resolve #66616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ const {
CHAR_COLON,
CHAR_QUESTION_MARK,
} = require('internal/constants');
const {
codes: {
ERR_INVALID_ARG_TYPE,
},
} = require('internal/errors');
const {
validateObject,
validateString,
Expand Down Expand Up @@ -196,7 +201,9 @@ const win32 = {
let path;
if (i >= 0) {
path = args[i];
validateString(path, `paths[${i}]`);
if (typeof path !== 'string') {
throw new ERR_INVALID_ARG_TYPE(`paths[${i}]`, 'string', path);
}

// Skip empty entries
if (path.length === 0) {
Expand Down Expand Up @@ -1254,7 +1261,9 @@ const posix = {

for (let i = args.length - 1; i >= 0 && !resolvedAbsolute; i--) {
const path = args[i];
validateString(path, `paths[${i}]`);
if (typeof path !== 'string') {
throw new ERR_INVALID_ARG_TYPE(`paths[${i}]`, 'string', path);
}

// Skip empty entries
if (path.length === 0) {
Expand Down
9 changes: 9 additions & 0 deletions test/parallel/test-path-resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ resolveTests.forEach(([resolve, tests]) => {
});
assert.strictEqual(failures.length, 0, failures.join('\n'));

for (const resolve of [path.posix.resolve, path.win32.resolve]) {
assert.throws(() => resolve('a', 1), {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: 'The "paths[1]" argument must be of type string. ' +
'Received type number (1)',
});
}

if (common.isWindows) {
// Test resolving the current Windows drive letter from a spawned process.
// See https://github.com/nodejs/node/issues/7215
Expand Down
Loading