Repository navigation
deps: update simdjson to 5.0.2 - #66495
Closed
nodejs-github-bot wants to merge 2 commits into
Closed
nodejs-github-bot wants to merge 2 commits into
nodejs-github-bot wants to merge 2 commits into
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
cjihrig
approved these changes
Oct 4, 2026
nodejs-github-bot
changed the title
nodejs-github-bot
force-pushed
the
actions/tools-update-simdjson
branch
from
October 5, 2026 15:20
78ef8a3 to
f5f115a
Compare
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
October 5, 2026 16:21
9d42073 to
378676b
Compare
richardlau
reviewed
Oct 5, 2026
Comment on lines
43
to
46
| FLAKY_TESTS: keep_retrying | ||
| CLANG_VERSION: '19' | ||
| CLANG_VERSION: '20' | ||
| CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19 | ||
| CXX: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang++-19 |
Member
There was a problem hiding this comment.
CC and CXX environment variables would need to be updated to clang-20/clang++-20 to match CLANG_VERSION.
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
October 5, 2026 16:36
378676b to
f292891
Compare
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
October 5, 2026 18:32
f292891 to
f95cd13
Compare
Member
|
I recommend closing this PR. A simdjson patch was just released and we can add a new change to improve build speed. So I am closing this PR. |
Member
|
The PR is superseded by #66620 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2026
PR-URL: #66620 Refs: simdjson/simdjson#2913 Refs: #66495 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2026
env.h includes inspector_profiler.h, which included simdjson.h for the types of two virtual methods and a parser member. As a result, about 155 files in src/ parsed the amalgamated simdjson header, which is over 10 MB. Keep simdjson out of inspector_profiler.h: the profile connections now say which field of `result` holds the profile, and WriteProfile() takes the profile as raw JSON. The parser becomes a local variable, so its buffers are no longer kept alive for the lifetime of the Environment. Also drop the unused include from node_task_runner.h, and let the config file reader rewind its document instead of parsing the whole file a second time with a second parser. Now only the eight files that use simdjson include it. On an Apple M-series machine, a clean rebuild of the src/ objects takes about 15% less CPU time (376 s to 320 s) and 19% less wall time at -j14. Signed-off-by: Daniel Lemire <daniel@lemire.me> PR-URL: #66620 Refs: simdjson/simdjson#2913 Refs: #66495 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of simdjson to 5.0.2.