Repository navigation
chore: setup benchmark compare - #24
Merged
Merged
Conversation
legendecas
force-pushed
the
bench-summary
branch
from
November 1, 2026 00:28
686c641 to
d728ffa
Compare
legendecas
force-pushed
the
bench-summary
branch
from
November 1, 2026 00:31
d728ffa to
cba2e7d
Compare
bengl
reviewed
Nov 1, 2026
bengl
left a comment
bengl
left a comment
Member
There was a problem hiding this comment.
Hmm, how should this work withthe pre-existing benchmark job in ci.yml? Maybe that one should run only on non-PR builds?
Member
Author
|
The pre-existing benchmark job will be the "push" event in the benchmark workflow, simply running the benchmark scripts on each push: https://github.com/nodejs/microtel/pull/24/changes#diff-aacbd0338bcf598920c120b69adaba2672acc7ea314cfca0f792bebe5fe2acd0R25-R28 |
Member
|
Alright SGTM. |
bengl
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the benchmark and compare a PR with the main (PR base) branch. The result will be shown on the GHA summary page as a reference.