Skip to content

chore: enable knip checks - #944

Closed
fengmk2 wants to merge 1 commit into
masterfrom
chore/enable-knip
Closed

fengmk2 wants to merge 1 commit into
masterfrom
chore/enable-knip

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 16, 2026

Copy link
Copy Markdown
Member

Unused files, exports, and dependencies can accumulate without a CI check. This change adds knip and runs vp run knip in the existing CI check job.

knip.jsonc includes examples and compiler fixtures and accounts for compiler packages that load dynamically. The change removes unused internal exports and @types/selfsigned, and retains UnidiciTimingInfo for compatibility.

@agentscanapp

agentscanapp Bot commented Oct 16, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedknip@​6.41.0991009596100

View full report

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@944

commit: 93cb584

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (b4a8ca0) to head (93cb584).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          10       10           
  Lines         746      746           
  Branches      235      235           
=======================================
  Hits          707      707           
  Misses         36       36           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2 fengmk2 closed this Oct 16, 2026
@fengmk2
fengmk2 deleted the chore/enable-knip branch October 16, 2026 16:06
fengmk2 added a commit that referenced this pull request Oct 16, 2026
Unused files, exports, and dependencies can accumulate without a CI
check. This change adds `fallow` and runs `vp run fallow` in the
existing CI check job. The command fails when it finds unused code or
dependencies.

`.fallowrc.jsonc` includes examples, compiler fixtures, and benchmarks,
and accounts for compiler packages that load dynamically. The change
removes unused internal exports and `@types/selfsigned`. Public type
annotations retain `UnidiciTimingInfo` and `RequestContext`.

Fallow is the selected implementation. In this repository, it ran
1.8–2.3 times faster than the `knip` alternative in #944.

| Mode | Knip | Fallow | Fallow speedup |
|---|---:|---:|---:|
| Current PR commands | 358 ms | 153 ms | 2.34× |
| Analysis caching disabled | 362 ms | 156 ms | 2.33× |
| Analysis caches warmed | 269 ms | 148 ms | 1.82× |

Measurements used Apple M4 Max, Node.js `24.22.0`, `knip` `6.41.0`, and
`fallow` `3.33.1`. Each value is the median of 20 runs after three
warm-up runs and includes CLI startup. The current PR commands use their
default cache settings: Knip disables analysis caching; Fallow enables
it. Results apply to this repository and machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant