Repository navigation
ci: adopt the shared npm release workflow - #729
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 8 8
Lines 260 260
Branches 42 42
=======================================
Hits 247 247
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
[Claude · review]
The workflow change looks correct: all three jobs pin 986b87b, Stage and Finalize keep the deployment environment that the Trusted Publisher setting expects, and automatic stage on package.json pushes is preserved.
Doc requests:
- Drop
docs/release-verification.md. It is a one-time log for a local candidate commit outside this PR; the PR description can carry that summary. - Trim
docs/releases.mdto what is specific to this package (Trusted Publisher values, thedeploymentenvironment, the operation steps) and link to the shared README for recovery. The Recovery list and the tooling-version line repeat the shared README and will go stale as the pin moves. - In "Updating the workflow", "caller contracts" is not defined for readers; say what to check, or drop the sentence.
Generated by Claude Code
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
gjbkz
left a comment
There was a problem hiding this comment.
[Claude · review]
All three doc requests are addressed and I found no new issues:
- The verification log is gone, and its summary is in the PR description.
- The guide keeps only package-specific steps and links the shared recovery procedure.
- The update checklist now says what to check.
The workflow is unchanged since the previous review.
Generated by Claude Code
[Codex · pr]
Replace inline release steps with pinned Verify, Stage and Finalize calls. Stage saves the package and source before npm approval; Finalize verifies public npm, publishes the saved GitHub Release and cleans up the source ref. Retain automatic staging and the
deploymentenvironment, and add the maintainer guide.Validation: all 47 tests, ESLint, guarded production Verify, workflow input and permission checks and actionlint passed. Both tarballs contain 23 files; cleanup removes only
devDependencies,eslintConfig,avaandrenovate. The other 22 files and all retained manifest fields are identical. Both installed CLI aliases passed valid/invalid-input checks.