Repository navigation
Accept an Io\Poll\Handle wherever a stream is taken - #1
Closed
nicolas-grekas wants to merge 1 commit into
Closed
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
PHP 8.6 lets an extension hand out an Io\Poll\Handle for something that can be waited on, and php_poll_handle_get_fd() turns any of them into a descriptor.
This was referenced Sep 21, 2026
Owner
Author
|
Let me close: php-src would rather keep the handle API internal to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs php/php-src#23810, which exports what an extension needs to recognise a handle.
PHP 8.6 adds
Io\Poll\Handle, the object an extension hands out for something that can be waited on. php/frankenphp#2636 is the first to ship them, a background worker and the two sides of a task, andphp_poll_handle_get_fd()turns any of them into a descriptor, sophp_event_zval_to_fd()takes one next to the streams and sockets it already accepts:The extension builds unchanged on 8.6 otherwise, and
make teststays at 28 passed, 0 failed with this.Opened here because Bitbucket refuses a fork of the upstream repo ("Forking to a different workspace is not allowed") and its issue tracker now answers 410.