Repository navigation
Fix date formatter - #1089
Merged
Merged
Fix date formatter#1089
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
… code they tested, so they didn't fail (relative minutes test was returning %dm and not failing) Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…es in minutes (i.e.: 5m) Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
daniele-verducci
force-pushed
the
fix/date-formatter
branch
from
October 22, 2026 16:38
2da2513 to
f476ced
Compare
alperozturk96
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed date formatter: for the minutes, it was passing only quantity with no formtArgs so always reported %dm instead of the values in minutes (i.e.: 5m).
This can be see e.g. in the Notes app, for a recently created note:
I also fixed tests: they computed the resulting value in the same way as the code they tested, so they didn't fail (relative minutes test was returning
%dm, tested against%dmand thus not failing)🏁 Checklist
🤖 AI (if applicable)