Repository navigation
Conversation
Schedules were built with `schedule && { name, cron }` and then filtered for `''` and `undefined`.
Any other falsy value (e.g. `null`) went to the API as a bare `null` entry in `function_schedules`.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: sending function schedules only when a function has a schedule. |
| Description check | |
The description directly explains the null-schedule bug and the intended fix. It is related to the changeset. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
seancdavis
left a comment
seancdavis
left a comment
There was a problem hiding this comment.
One comment from my 🤖
| const functionSchedules = functionZips | ||
| .map(({ name, schedule }) => schedule && { name, cron: schedule }) | ||
| .filter((schedule): schedule is { name: string; cron: string } => schedule !== '' && schedule !== undefined) | ||
| const functionSchedules = functionZips.flatMap(({ name, schedule }) => (schedule ? [{ name, cron: schedule }] : [])) |
There was a problem hiding this comment.
[consider] I don't think the null ever reached the API. deploySite runs the whole payload through cleanDeep before sending it (deploy-site.ts:223), and that drops null entries from arrays too.
Still worth doing for the type guard. But as a fix: it'll land in the changelog as a bug users hit.
2 participants
Summary
Teeny, tiny nitpicky follow-up issue caught by the type improvements in #8599.
Schedules were built with
schedule && { name, cron }and then filtered for''andundefined.Any other falsy value (e.g.
null) went to the API as a barenullentry infunction_schedules.