Repository navigation
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The description directly covers the deploy polling, drop-upload retry, and backoff changes in the changeset. |
| Title check | |
The title clearly summarizes the main refactoring of deploy polling, retries, and streams. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
Review with "hide whitespace"!
📊 Benchmark resultsComparing with 2e5bc91
|
commit: |
| // eslint-disable-next-line @typescript-eslint/no-misused-promises -- FIXME: the listener's promise is discarded | ||
| fibonacciBackoff.on('ready', tryUpload) | ||
| fibonacciBackoff.on('ready', (retryIndex) => { | ||
| void tryUpload(retryIndex) |
There was a problem hiding this comment.
We intentionally don't await this promise. We handle errors via emitted events.
Batch 3 of 3 of follow-ups to #8599 ([batch 1](#8605), [batch 2](#8626)). Out of an abundance of caution, that PR was kept purely focused on type changes. - Share one poller between `waitForDiff` and `waitForDeploy` instead of duplicating code - Resolve the drop deploy poll with the ready deploy - `waitForDropDeploy` captured the ready deploy in an outer variable and returned it with a non-null assertion after polling. The poll now resolves with it directly via `pWaitFor.resolveWith`. - Rethrow the final drop upload error from inside the retry loop - The drop file upload retry loop remembered the last error, skipped the backoff on the final attempt, and threw the remembered error after the loop. It now throws directly on a permanent failure or on the last attempt, and otherwise backs off and retries. The status is read through an `instanceof Error` guard instead of a cast. - Don't return the upload promise to the backoff emitter. It wasn't used, resulting in lint errors about promise misuse.
81666c0 to
0bd59b6
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 participants
Summary
Batch 3 of 3 of follow-ups to #8599 (batch 1, batch 2). Out of an abundance of caution, that PR was kept purely focused on type changes.
waitForDiffandwaitForDeployinstead of duplicating codewaitForDropDeploycaptured the ready deploy in an outer variable and returned it with a non-null assertion after polling. The poll now resolves with it directly viapWaitFor.resolveWith.attempt, and threw the remembered error after the loop. It now throws directly on a permanent failure or on the last attempt, and otherwise backs off and retries. Simplify all this.