Repository navigation
Call a shop 店舗 in Japanese - #151
Merged
Merged
Conversation
ja.yml mixed 店舗名 (the shop's name attribute) with ショップ elsewhere, so a validation error could say 店舗名 and a limit error ショップ. Use 店舗 throughout, as myturntagapi does, and fail a test on any ショップ. The agent's rename.rb rewrites only the English spellings of Shop, so these Japanese values are unaffected, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WyUzNEPWyhjjWrBcSaXSW4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/locales/ja.ymlmixed 店舗名 (the shop'snameattribute) with ショップ in four other places, so one error could say 店舗名 and the next ショップ. All four now say 店舗, as myturntagapi does (#210 there):activerecord.models.shopitem_tag.shoperrors.messages.limit_count_shopdefault_shop_descriptiontest/i18n/japanese_messages_test.rbfails on any ショップ in the Japanese translations.nativeapptemplate-agent
scripts/ruby/rename.rbrewrites only the English spellings of the renamed models (Shop/shop/shops…) in.ymlfiles. The YAML keys still rename together with the model, and the Japanese values stay as they are, just as ショップ did before.Testing
ja.yml.bin/rails test: 584 runs, 0 failures. rubocop and brakeman are clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01WyUzNEPWyhjjWrBcSaXSW4