Repository navigation
Match the time zone list to Rails - #102
Merged
Merged
Conversation
The list lacked Asuncion (added in Rails 7.1) and labelled five zones with outdated offsets: Greenland (-02:00 since 2023), Almaty and Astana (+05:00 since 2024), and Dublin and Casablanca (+00:00 in Rails). The offsets also drive the device default, so America/Nuuk picked Mid-Atlantic instead of Greenland and America/Asuncion picked Brasilia. The list is now ActiveSupport::TimeZone.all from nativeapptemplateapi (activesupport 8.1.4), and TimeZoneDataTest compares it with that output. Dublin and Casablanca now match the system's standard offset, so the comment in currentTimeZone no longer cites them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeZoneData.swiftnow equalsActiveSupport::TimeZone.allfrom nativeapptemplateapi (activesupport 8.1.4): adds Asuncion (Rails 7.1), relabels Greenland to -02:00 (since 2023), Almaty/Astana to +05:00 (since 2024), Dublin/Casablanca to +00:00, and follows Rails' order.Utility.currentTimeZone), so America/Nuuk picked Mid-Atlantic instead of Greenland, and America/Asuncion picked Brasilia.TimeZoneDataTestembeds the Rails output as the oracle (bin/rails runner 'ActiveSupport::TimeZone.all.each { |z| puts "#{z.name}\t#{z}" }'in nativeapptemplateapi) and checks the Nuuk/Asuncion defaults.currentTimeZonecited Dublin and Casablanca as cities whose table offset differs from the system's; both now match (standard offset +00:00), so it no longer names them. The logic is unchanged and existingUtilityTestexpectations still hold.Port of dadachi/MyTurnTagCreator-iOS#149.
Test plan
TimeZoneDataTeston iPhone (device) before the fix: 3 tests failed with 4 issues (keys, labels, Asuncion, Nuuk)TimeZoneDataTestpasses; full suite on device: 437 tests in 68 suites passed (1 known issue, the intentional one inWaitUntilTest)make lintpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01YDK5huvuRECyVrsQEdTN9q