Add deterministic visual authoring independence regressions - #1345
Merged
multiplex55 merged 1 commit intoAug 23, 2026
Merged
multiplex55 merged 1 commit into
multiplex55 merged 1 commit into
Conversation
multiplex55
deleted the
codex/add-focused-integration-tests-for-action-editor
branch
August 28, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VisualCaptureWorkflowinside a realActionEditorStatefixture so terminal outcomes are restored and applied only through the normal editor paths.Description
VisualCaptureWorkflowintoActionEditorStatewith fakeVisibilityAdapter,WorkflowClock,RectangleOverlay,CaptureAdapter, andAssetStoreAdapter.MkImagePayloadcontainingasset_id = 7andSearchRegion::Rectangle { rect: ScreenRect::new(100,100,800,600) }, and snapshot/clone unrelated payload fields before operations to assert they remain unchanged.ImageSearchEditorStatecomparable by derivingPartialEq/Eqto enable byte-for-byte or field-for-field equality assertions in cancellation and stale-token tests.Testing
git diff --checkwas run and passed for the patch format.cargo test visual_authoring_independence --libwas invoked; compilation progressed but a full run is blocked on platform-specific unconditional Windows API imports when building on Linux (the test logic itself is platform-agnostic and uses the fake adapters).rustfmt/cargo fmt) and modified files were formatted as part of the change.Codex Task