Repository navigation
Upgrade Sass to 1.105.2 - #1186
Open
stephaniehobson wants to merge 1 commit into
Open
stephaniehobson wants to merge 1 commit into
stephaniehobson wants to merge 1 commit into
Conversation
Sass 1.92.0 emits declarations in source order, so the & {} wrappers
added to avoid mixed-decls warnings are no longer needed. Also bump
@parcel/watcher, which was held back with the Sass pin.
knowler
approved these changes
Oct 27, 2026
| "url": "https://github.com/mozilla/protocol.git" | ||
| }, | ||
| "engines": { | ||
| "node": ">=16.0.0" |
Collaborator
There was a problem hiding this comment.
The Sass version we’ve pinned requires a newer version than this (https://npmx.dev/package/sass/v/1.105.2#compatibility). We’ll need to reflect this in AGENTS.md and probably inlcude a line in CHANGELOG.md too.
Suggested change
| "node": ">=20.19.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A long awaited Sass update!!!!
I have documented this change in the design system.CHANGELOG.md.Issue
n/a
Testing
✅ Visual regression tests pass locally.
Does it build for you?