Repository navigation
PYTHON-5315 Fix racy test_recover_from_initially_empty_seedlist and t… - #3143
Merged
Merged
Conversation
…est_recover_from_initially_erroring_seedlist
NoahStapp
marked this pull request as ready for review
October 26, 2026 20:02
NoahStapp
requested review from
sleepyStick
and
a balanced review from Copilot
October 26, 2026 20:02
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes preserve recovery assertions and address the timing gap without introducing identified blocking issues.
No open issues 🎉
What changed in this PR
This PR addresses timing races in the SRV polling recovery tests by keeping polling timing overrides active while resolver callbacks change.
Changes:
- Keep the short TTL and rescan interval patched across both recovery phases.
- Nest callback-specific patches without changing the recovery assertions.
| File | Description |
|---|---|
test/test_srv_polling.py |
Mirrors the nested patch structure in the generated synchronous tests. |
test/asynchronous/test_srv_polling.py |
Preserves timing overrides across resolver callback transitions. |
Review effort: Balanced
sleepyStick
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…est_recover_from_initially_erroring_seedlist
PYTHON-5315
Changes in this PR
Fixed racy test to use the correct pattern of nesting
SrvPollingKnobsto prevent a real DNS poll from sneaking out between patched ones and failing the test.Test Plan
Existing test changes.
Checklist
Checklist for Author
Checklist for Reviewer