Repository navigation
PYTHON-6111 C extension accepts BSON documents where element data overlaps the document terminator - #3113
Draft
blink1073 wants to merge 1 commit into
Draft
PYTHON-6111 C extension accepts BSON documents where element data overlaps the document terminator#3113blink1073 wants to merge 1 commit into
blink1073 wants to merge 1 commit into
Conversation
…ument terminator
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The bounds checks correctly enforce BSON document boundaries and are covered by focused regression tests.
0 open findings
What changed in this PR
Aligns the C BSON decoder with the pure-Python decoder by rejecting element data that consumes a document terminator.
Changes:
- Adds boolean and regex bounds checks.
- Adds regression coverage across buffer types and decode paths.
- Documents the fix in the changelog.
| File | Description |
|---|---|
bson/_cbsonmodule.c |
Prevents boolean and regex values from overlapping the terminator. |
test/test_bson.py |
Tests malformed boolean and regex documents. |
doc/changelog.rst |
Records the PYTHON-6111 fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6111
Changes in this PR
InvalidBSON.Test Plan
test/test_bson.pysuite andjust lint-manualpass.just typing(mypy) crashes on an environment issue unrelated to this diff; re-run on a clean checkout before merge.Checklist
Checklist for Author
Checklist for Reviewer