Skip to content

fix(web): .zip cant be fabric - #8154

Merged
mergify[bot] merged 1 commit into
mainfrom
cal/fabric-jar-zip-fix-018421
Nov 2, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
cal/fabric-jar-zip-fix-018421

Conversation

@IMB11

@IMB11 IMB11 commented Oct 29, 2026

Copy link
Copy Markdown
Member

Closes #8119

Fixes issue where inference finds fabric.mod.json and assumes it's fabric, even though mods must be .jar

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Note

This changelog has been baked. Any further edits will not be reflected.

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

  • Fixed issue where uploading a version where fabric.mod.json in .zip files incorrectly classifies it as a Fabric mod, even though Fabric mods must be .jar

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@github-actions

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is e1ab5fc0628299c85d9c8a412f39546bc5e65f71

Persistent

Environment URL
staging https://pr-8154.frontend-staging.rinth.dev
production https://pr-8154.frontend.rinth.dev
storybook https://pr-8154-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://503e4aeb.frontend-staging.rinth.dev
production https://816c4d17.frontend.rinth.dev

@mergify

mergify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@IMB11

IMB11 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Merged into main as 10dd511 at 15:42 UTC

9 min in the queue, 6 min of it CI.

So far

2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-success = Lint and Test
    • check-neutral = Lint and Test
    • check-skipped = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 2, 2026
@mergify
mergify Bot merged commit 10dd511 into main Nov 2, 2026
12 checks passed
@mergify
mergify Bot deleted the cal/fabric-jar-zip-fix-018421 branch November 2, 2026 15:42
@mergify mergify Bot removed the queued label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Missing client-side validation for incompatible project file types

2 participants