Repository navigation
fix: align filtered token timestamps and reject incomplete input - #3803
Merged
Merged
Conversation
sentence_postprocess drops <s>, </s>, <unk> and <OOV> from the tokens but then indexed time_stamp by the washed position. time_stamp has one entry per token, so every word after a filtered token took the previous token's time. Keep the entries of the surviving tokens. A list too short to cover them stays as it was, because the branches below index it directly.
Keep the filtered-token index fix and reject missing retained-token timestamps explicitly. Preserve valid trailing special tokens and untimed transcription. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This was referenced Oct 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the original contributor commit from #3802 and complete its timestamp alignment contract on a maintainer-owned branch. The fork is left unchanged.
Validation
This is separate from #3801's VAD chunk concatenation issue. It does not change or republish v1.4.17.