Skip to content

ci(e2e): remove PR event and unify registry login - #284

Merged
chlins merged 1 commit into
mainfrom
chore/skip-e2e-for-pr
Sep 16, 2025
Merged

chlins merged 1 commit into
mainfrom
chore/skip-e2e-for-pr

Conversation

@chlins

@chlins chlins commented Sep 16, 2025

Copy link
Copy Markdown
Member

This pull request updates the GitHub Actions workflow configuration for end-to-end (E2E) tests. The main change is the removal of the workflow trigger for pull requests and the associated conditional authentication logic, simplifying the workflow to only run on pushes, scheduled events, and manual dispatches.

Workflow trigger changes:

  • Removed the pull_request trigger from the on: section in .github/workflows/e2e.yml, so E2E tests will no longer run automatically on pull requests.

Authentication logic simplification:

  • Removed conditional logic and Personal Access Token (PAT) authentication for pull requests in the E2E job steps; now, the workflow always uses the GITHUB_TOKEN for authentication.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@chlins chlins added the enhancement New feature or request label Sep 16, 2025

@bergwolf bergwolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chlins
chlins merged commit df24faa into main Sep 16, 2025
@chlins
chlins deleted the chore/skip-e2e-for-pr branch September 16, 2025 04:25
SAY-5 added a commit to SAY-5/modctl that referenced this pull request May 2, 2026
Signed-off-by: SAY-5 <say.apm35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants