Repository navigation
fix(codemod): retain patch versions when classifying Zod upper bounds - #3051
Open
pacocartones wants to merge 1 commit into
Open
pacocartones wants to merge 1 commit into
pacocartones wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 269b32b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
claude
Bot
added
the
v2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain patch versions when the codemod classifies Zod upper bounds.
Motivation and Context
The migrator warns that
>=4.2.0 <4.2.1cannot satisfy Zod 4.2.0 because its upper-bound classifier discards the patch version. Retain that component so ranges admitting 4.2.0 do not receive the warning. This also keeps<4.0.1in the Zod 4.0/4.1 diagnostic instead of the Zod 3 diagnostic.How Has This Been Tested?
Eight manifest-level cases cover exclusive and inclusive bounds, partial versions and unchanged dependency ranges. Four cases fail without the fix. The codemod package's 653 tests, typecheck, lint, formatting and build pass. The whole SDK test matrix was not run locally; this was package-level validation, not an external application run.
Breaking Changes
None. Dependency ranges are unchanged; the fix corrects warning classification.
Types of changes
Checklist
Additional context
A patch changeset is included. No SDK runtime or dependency changes. The general test checkbox remains unchecked because only the codemod package was validated locally. The change adjusts an existing diagnostic and adds no new error-handling path; no documentation changes were made.