fix(docker): upgrade npm in TypeScript builders - #4832
Open
lyxnbclass wants to merge 1 commit into
Open
lyxnbclass wants to merge 1 commit into
lyxnbclass wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade npm in the four TypeScript Docker builder stages before installing package dependencies. The builder images bundle npm 10.x, whose Arborist resolver crashes on the current Vitest peer dependency graph.
Server Details
Motivation and Context
Fixes #4782.
npm 10.9.0 and npm 11.5.1 both reproduce
Cannot read properties of null (reading 'edgesOut'). npm 11.12.1 resolves the same dependency graph successfully. The chosennpm@^11.5.1range matches the repository's existing release workflow.How Has This Been Tested?
preparebuilds completed.npm testinsrc/everything: 107 tests passed.npm testinsrc/filesystem: 168 tests passed.npm testinsrc/memory: 87 tests passed.npm testinsrc/sequentialthinking: 26 tests passed.Breaking Changes
None.
Types of changes
Checklist
Additional context
This overlaps with #4787, which was discovered after the local implementation was complete. This version keeps the npm upgrade and dependency install in the existing cache-mounted layer.