fix(model): reject malformed JSON-RPC messages with conflicting result and error fields (#1283) - #1287
Open
ump45nose wants to merge 2 commits into
Open
fix(model): reject malformed JSON-RPC messages with conflicting result and error fields (#1283)#1287ump45nose wants to merge 2 commits into
ump45nose wants to merge 2 commits into
Conversation
Keep the public Deserialize impl equivalent to the previous derive (Deserialize<'de> bounds, Noti type param) so cargo public-api --deny removed passes, while still rejecting conflicting result/error fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(model): reject malformed JSON-RPC messages with conflicting result and error fields (#1283)
Verification
cargo test -p rmcp --lib (205 passed; includes test_response_with_result_and_error_is_rejected, test_request_with_stray_result_or_error_is_rejected, and test_clean_shapes_and_extension_fields_still_deserialize)
Related to #1283