Repository navigation
scripts: fix client-conformance.sh on Windows and with a relative --result_dir - #1366
Open
Shreyasg13 wants to merge 1 commit into
Open
Shreyasg13 wants to merge 1 commit into
Shreyasg13 wants to merge 1 commit into
Conversation
…esult_dir client-conformance.sh fails every client check in two cases. On Windows, it builds the client as `conformance-client` with no extension. The conformance runner starts `--command` through cmd.exe, which can't run a file without `.exe`, so all 42 checks fail with "'.../conformance-client' is not recognized as an internal or external command". The script now appends `go env GOEXE`, which is ".exe" on Windows and empty elsewhere. With a relative --result_dir, such as `./conformance-results` from CONTRIBUTING.md, the script cds into that directory and then passes the same relative path in `--command`, so the client is not found on any OS. The script now resolves --result_dir to an absolute path first. CI is unaffected: its client job runs the runner directly with `go run ./conformance/everything-client`. AI disclosure: this change was written with Claude Code (Claude Opus 5.5). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/client-conformance.shfails every client check in two cases.Windows. The script builds the client as
conformance-client, with no extension. The conformance runner starts--commandthrough cmd.exe, which can't run a file without.exe, so all 42 checks fail with:The script now builds
conformance-client$(go env GOEXE).GOEXEis.exeon Windows and empty elsewhere.Relative
--result_dir(any OS). With the example from CONTRIBUTING.md,--result_dir ./conformance-results, the scriptcds into that directory and then passes the same relative path in--command, so the client isn't found:The script now resolves
--result_dirto an absolute path first. That also puts results in the directory you asked for, not in a nested copy of it.CI is unaffected: its client job runs the runner directly with
go run ./conformance/everything-client.Testing (core suite,
@modelcontextprotocol/conformance0.1.16):main--result_dir--result_dir--result_dirnot foundThe Linux rows ran on GitHub Actions in my fork.
bash -nis clean.AI disclosure: this change was written with Claude Code (Claude Opus 5.5); I reviewed it and the test results.