Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppBridge.setHostContext()returns void but discards the promise fromsendHostContextChange(). Updating context before connecting or after disconnecting therefore produces an unhandledNot connectedrejection. A transport send failure while connected is also left unhandled. Related downstream reports: MCP-UI-Org/mcp-ui#195 and MCP-UI-Org/mcp-ui#208.Keep disconnected updates in the context returned by the next initialization handshake, and route notification failures through the existing
onerrorcallback. The low-levelsendHostContextChange()API is unchanged. Add regressions using linked App/AppBridge transports for initial connection, reconnection, and a failed send; all three fail on the original code and pass with this change.Validation on Windows, Node 24.14.1 / Bun 1.3.10:
npm test: 441 passed, 2 skipped.npm run build,npm run examples:build, and TypeDoc link validation passed.CLAUDE.mdsymlink checked out as a regular file on Windows.