Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple
AppBridgeviews share one MCPClient, each connection replaces the client's tools/resources/prompts list-change handlers. Earlier views stop receiving updates, and closing the newest view leaves forwarding pointed at a closed connection.Share one dispatcher per client and notification method. Forward only to Apps-ready views, and remove each bridge's subscription on local or remote disconnect and failed connection setup. Reconnecting a bridge does not duplicate subscriptions or replace the user's
onclosecallback.Automatic forwarding still owns the single-handler slots on first use and replaces any pre-existing handlers. If a caller later replaces a slot, bridge joins, closes and reconnects leave that handler in place; automatic forwarding for that method stays superseded. Empty dispatcher sets are retained to avoid removing or reinstalling a caller-owned handler. Hosts needing custom forwarding can continue to pass
nullas the client.Validation:
tsc --noEmitpasses with the repository's full tsconfig, including the new regression tests, React sources and documentation examples. The unchangedbuild.bun.tscompletes declaration emission and all six JavaScript bundle entry points.npm run buildwere not run.AI assistance: OpenAI Codex generated the implementation, tests and this description. This disclosure does not claim independent human review.