Repository navigation
ci(publishing): replace direct NuGet push with ESRP release - #3189
Merged
Gavin Barron (gavinbarron) merged 1 commit intoOct 6, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Gavin Barron (gavinbarron)
October 6, 2026 18:01
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The production publishing integration depends on private ESRP configuration that cannot be fully validated from the repository.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates NuGet.org publishing from direct push to ESRP while retaining the existing build, signing, approval, and GitHub release flow.
Changes:
- Stages NuGet and symbol packages separately.
- Publishes through
EsrpRelease@14. - Removes the unused NuGet installer.
| File | Description |
|---|---|
.azure-pipelines/ci-build.yml |
Configures ESRP-based NuGet publishing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adrian (adrian05-ms)
approved these changes
Oct 6, 2026
Gavin Barron (gavinbarron)
deleted the
gavinbarron-esrp-nuget-publishing
branch
October 6, 2026 19:07
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
1ES.PublishNuget@1direct publishing withEsrpRelease@14, using the existing ESRP service connection, certificates, client ID, and tenant ID, with NuGet organizationmicrosoftgraph..nupkgand.snupkgfiles separately from release scripts and wait for ESRP completion before uploading GitHub release assets. Remove the unused NuGet tool installer.Other links
Microsoft Reviewers: Open in CodeFlow