Repository navigation
fix(pytest): support parameterized tests with unbracketed names (e.g., pytest.HIDDEN_PARAM) - #26233
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 4 commits into
Conversation
…pytest.HIDDEN_PARAM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25795
When a test is parameterized using
pytest.HIDDEN_PARAM(e.g.@pytest.mark.parametrize('setup', [pytest.param('setup', id=pytest.HIDDEN_PARAM)])), pytest does not append a bracketed parameter identifier[...]to the test item name. During test discovery,vscode_pytest.process_parameterized_testattemptedtest_node['name'].split('[', 1), raising:ValueError: not enough values to unpack (expected 2, got 1)and failing test discovery.
Changes
python_files/vscode_pytest/__init__.py:is_parameterizedcheck inbuild_test_treeto verify'[' in test_node['name']in addition tohasattr(test_case, 'callspec').process_parameterized_test, added a guard returningtest_nodeif'[' not in test_node['name'].build_test_treeto handle tests wherenot is_parameterized.python_files/tests/pytestadapter/test_utils.pyverifying that tests usingpytest.HIDDEN_PARAMdiscover successfully and build the expected test tree without errors.Verification
python3 -m pytest python_files/tests/pytestadapter/test_utils.py(all 4 passed).