Dismiss notification without opening PR Overview #3859

Activity

1. Benjamin Christopher Simmonds (benibenj)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   on Aug 17, 2022
2. Benjamin Christopher Simmonds (benibenj)

   added this to the August 2022 milestone on Aug 17, 2022
3. Benjamin Christopher Simmonds (benibenj)

   self-assigned this

   on Aug 17, 2022
4. Benjamin Christopher Simmonds (benibenj)

   modified the milestones: August 2022, September 2022 on Aug 22, 2022
5. Benjamin Christopher Simmonds (benibenj)

   linked a pull request that will close this issueRight click to dismiss notification #3917on Sep 2, 2022
6. Benjamin Christopher Simmonds (benibenj)

   closed this as completedin #3917on Sep 5, 2022
7. Benjamin Christopher Simmonds (benibenj)

   added

   verification-neededVerification of issue is requestedVerification of issue is requested

   on Sep 26, 2022
8. benibenj commented on Sep 26, 2022

   

   Benjamin Christopher Simmonds (benibenj)

   on Sep 26, 2022

   ContributorAuthor

   More actions

   GitHub Pull Request Notifications can now be dismissed by right clicking on the PR tree node.

   1. Test by creating a notification for a PR (ask someone else (or second account) comments on your PR maybe?)
   2. Right click the PR which has the notification. Click the dismiss notification option
9. Joyce Er (joyceerhl)

   added

   verifiedVerification succeededVerification succeeded

   and removed

   verifiedVerification succeededVerification succeeded

   on Sep 28, 2022
10. TylerLeonhardt commented on Sep 29, 2022

    

    TylerLeonhardt

    on Sep 29, 2022

    Member

    More actions

    This has been working on-and-off for me... not sure why...
    from what I can tell you is...

    1. have a PR in a repo
    2. checkout main
    3. focus the PR view
    4. leave it focused ...don't unfocus the PR view at all
    5. have someone trigger a notification on that PR

    Two bugs from what I can tell.

    1. After they comment, hit the refresh button in the PR view... no notification shows up 🐛

    2. Now focus the issues view

    3. Notification in PR view pops up... right click on it

    🐛 No option to dismiss a notification
    

    Now click refresh PR view.... the dismiss a notification option is now there.
11. TylerLeonhardt

    reopened this on Sep 29, 2022
12. TylerLeonhardt

    added

    verification-foundIssue verification failedIssue verification failed

    on Sep 29, 2022
13. Alex Ross (alexr00)

    modified the milestones: September 2022, October 2022 on Sep 30, 2022
14. benibenj commented on Sep 30, 2022

    

    Benjamin Christopher Simmonds (benibenj)

    on Sep 30, 2022

    ContributorAuthor

    More actions

    I was not able to make this fix today. However, it should not be that hard. On the PRNode we could just listen for the notification change event and get the PRIdentifier from the uri to compare with the PR model and figure out if the node has to be refreshed or not.
15. Peng Lyu (rebornix)

    modified the milestones: October 2022, November 2022 on Oct 25, 2022
16. Alex Ross (alexr00)

    assigned

    Alex Ross (alexr00)

    and unassigned

    Benjamin Christopher Simmonds (benibenj)

    on Nov 28, 2022
17. Alex Ross (alexr00)

    modified the milestones: November 2022, On Deck on Nov 28, 2022
18. Alex Ross (alexr00)

    removed

    verification-foundIssue verification failedIssue verification failed

    verification-neededVerification of issue is requestedVerification of issue is requested

    on Dec 9, 2025
19. Alex Ross (alexr00)

    assigned

    Copilot

    on Dec 9, 2025
20. Alex Ross (alexr00)

    assigned

    Copilot

    and unassigned

    Copilot

    on Oct 29, 2026
21. Copilot commented on Oct 29, 2026

    

    CopilotAI

    on Oct 29, 2026

    Contributor

    More actions

    The agent encountered an error and was unable to start working on this issue: Please try again later, or contact support if the problem persists. (Request id: E778:1050E2:1092987:1862003:6AE32D56)