Skip to content

C-WCOW: Unify data structures and reuse for C-LCOW and C-WCOW - #2544

Merged
Hamza El-Saawy (helsaawy) merged 9 commits into
microsoft:mainfrom
MahatiC:refactoring-confidential
Dec 22, 2025
Merged

C-WCOW: Unify data structures and reuse for C-LCOW and C-WCOW#2544
Hamza El-Saawy (helsaawy) merged 9 commits into
microsoft:mainfrom
MahatiC:refactoring-confidential

Conversation

@MahatiC

@MahatiC Mahati Chamarthy (MahatiC) commented Oct 28, 2025

Copy link
Copy Markdown
Member
  • This change repurposes existing data structures and uses them for both C-LCOW and C-WCOW

KenGordon
KenGordon reviewed Oct 29, 2025
View reviewed changes
Comment thread internal/uvm/start.go Resolved
KenGordon
KenGordon reviewed Oct 29, 2025
View reviewed changes
Comment thread internal/gcs-sidecar/host.go Resolved
KenGordon
KenGordon reviewed Oct 29, 2025
View reviewed changes
Comment thread internal/gcs-sidecar/host.go Resolved
@MahatiC Mahati Chamarthy (MahatiC) mentioned this pull request Oct 29, 2025
Merged
ambarve
Amit Barve (ambarve) reviewed Oct 29, 2025
View reviewed changes
Comment thread internal/uvm/start.go Resolved
ambarve
Amit Barve (ambarve) reviewed Oct 29, 2025
View reviewed changes
Comment thread internal/uvm/security_policy.go Resolved
@MahatiC
Mahati Chamarthy (MahatiC) force-pushed the refactoring-confidential branch 3 times, most recently from 990fe18 to 8cfcea8 Compare October 31, 2025 16:17
@MahatiC Mahati Chamarthy (MahatiC) mentioned this pull request Nov 3, 2025
Merged
@MahatiC
Mahati Chamarthy (MahatiC) force-pushed the refactoring-confidential branch 3 times, most recently from 5d6a794 to 309345c Compare November 5, 2025 11:47
@MahatiC
Mahati Chamarthy (MahatiC) marked this pull request as ready for review November 6, 2025 09:03
@MahatiC
Mahati Chamarthy (MahatiC) requested a review from a team as a code owner November 6, 2025 09:03
KenGordon
KenGordon reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/securitypolicy/securitypolicy_linux.go Resolved
KenGordon
KenGordon reviewed Nov 6, 2025
View reviewed changes
Comment thread pkg/securitypolicy/securitypolicy_options.go Resolved
@micromaomao Tingmao Wang (micromaomao) mentioned this pull request Nov 11, 2025
Merged
@MahatiC

Mahati Chamarthy (MahatiC) commented Nov 24, 2025

Copy link
Copy Markdown
Member Author

Maksim An (@anmaxvl) Could you review this PR too?

@MahatiC
Mahati Chamarthy (MahatiC) force-pushed the refactoring-confidential branch 3 times, most recently from c4bfa1c to 9f69e49 Compare December 3, 2025 16:18
@anmaxvl Maksim An (anmaxvl) self-assigned this Dec 4, 2025
anmaxvl
Maksim An (anmaxvl) reviewed Dec 5, 2025
View reviewed changes
Comment thread cmd/gcs-sidecar/main.go Resolved
Comment thread internal/uvm/start.go Resolved
@MahatiC
C-WCOW: Unify data structures and reuse for C-LCOW and C-WCOW
ee83765 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: Move gcs-sidecar confidential options to securitypolicy pkg
cf6b89e 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: Move security policy config from LCOW gcs
e090d17 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: Move InjectFragment to securitypolicy pkg
93ec4eb 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: Move securitycontext dir to securitypolicy pkg
8809b5f 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: PspDriver and hostdata changes in SecurityPolicy pkg
83a71d4 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@MahatiC
C-WCOW: Cleanup confidential options
1bf838e 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@anmaxvl

Maksim An (anmaxvl) commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Mahati Chamarthy (@MahatiC) , I think we should have something like this in the end:

pkg/
└── amdsevsnp/
    ├── report.go
    ├── report_windows.go
    ├── report_linux.go
    └── validate.go
  • report.go - platform independent code, the exported attestation report fetching (raw/parsed) methods and all the shared type/struct definitions (you'll dedup a good chunk of internal/pspdriver/pspdriver.go code as well)
  • report_windows.go - windows specific code to fetch the report (i.e. pspdriver.go code without the shared type definitions) and any additional windows specific definitions we may need
  • report_linux.go - linux specific code to fetch the report (report.go content minus type/struct and IOCTL code)
  • validate.go - platform independent host data validation code

@MahatiC
C-WCOW: Hardware checks and reports in separate pkg
948c16f 
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
@KenGordon

KenGordon commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator

Hamza El-Saawy (@helsaawy) can this be merged now?

helsaawy
Hamza El-Saawy (helsaawy) reviewed Dec 22, 2025
View reviewed changes

@helsaawy Hamza El-Saawy (helsaawy) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, lgtm otherwise

Comment thread internal/uvm/create.go Resolved
helsaawy
Hamza El-Saawy (helsaawy) approved these changes Dec 22, 2025
View reviewed changes

@helsaawy Hamza El-Saawy (helsaawy) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, lgtm otherwise

@helsaawy
Hamza El-Saawy (helsaawy) merged commit e3ffe3d into microsoft:main Dec 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmaxvl Maksim An (anmaxvl) anmaxvl approved these changes
@helsaawy Hamza El-Saawy (helsaawy) helsaawy approved these changes
+2 more reviewers
@KenGordon KenGordon KenGordon left review comments
@ambarve Amit Barve (ambarve) ambarve left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@anmaxvl Maksim An (anmaxvl)

@helsaawy Hamza El-Saawy (helsaawy)

Labels

clcow cwcow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MahatiC @anmaxvl @KenGordon @ambarve @helsaawy