Skip to content

Restart a file's imports when a later arrival lowers its node_modules depth #64632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Branch (andrewbranch) merged 2 commits into from
Oct 5, 2026
Merged

Restart a file's imports when a later arrival lowers its node_modules depth #64632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a9abba
Restart a file's imports when a later arrival lowers its node_modules…
cplieger Oct 5, 2026
3e62a5f
Replace the unit test with a compiler test
cplieger Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tsc/internal/compiler/filesparser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ func (w *filesParser) start(loader *fileLoader, tasks []*parseTask, depth int) {
}

currentDepth := core.IfElse(task.increaseDepth, depth+1, depth)
if currentDepth < data.lowestDepth {
lowered := currentDepth < data.lowestDepth
if lowered {
// If we're seeing this task at a lower depth than before,
// reprocess its subtasks to ensure they are loaded.
data.lowestDepth = currentDepth
Expand All @@ -324,7 +325,7 @@ func (w *filesParser) start(loader *fileLoader, tasks []*parseTask, depth int) {
data.startedSubTasks = true
}
}
if !taskByFileName.startedSubTasks && loadSubTasks {
if loadSubTasks && (lowered || !taskByFileName.startedSubTasks) {
taskByFileName.startedSubTasks = true
w.start(loader, taskByFileName.subTasks, data.lowestDepth)
}
Expand Down
43 changes: 43 additions & 0 deletions ...ata/baselines/reference/compiler/symlinkedPackageReachedRelativelyIsNotExternalLibrary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
//// [tests/cases/compiler/symlinkedPackageReachedRelativelyIsNotExternalLibrary.ts] ////

//// [package.json]
{ "name": "lib", "types": "index.ts" }

//// [index.ts]
export { util } from "./util";

//// [util.ts]
export const util = 1;

//// [a.ts]
import { util } from "./lib/index";
export const a = util;

//// [b.ts]
import { util } from "lib";
export const b = util;


//// [util.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.util = void 0;
exports.util = 1;
//// [index.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.util = void 0;
var util_1 = require("./util");
Object.defineProperty(exports, "util", { enumerable: true, get: function () { return util_1.util; } });
//// [a.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.a = void 0;
const index_1 = require("./lib/index");
exports.a = index_1.util;
//// [b.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.b = void 0;
const lib_1 = require("lib");
exports.b = lib_1.util;
27 changes: 27 additions & 0 deletions tsc/testdata/tests/cases/compiler/symlinkedPackageReachedRelativelyIsNotExternalLibrary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// @noTypesAndSymbols: true

// @filename: /src/tsconfig.json
{
"compilerOptions": { "outDir": "out", "module": "commonjs", "target": "es2015" },
"files": ["a.ts", "b.ts"]
}

// @filename: /src/a.ts
import { util } from "./lib/index";
export const a = util;

// @filename: /src/b.ts
import { util } from "lib";
export const b = util;

// @filename: /src/lib/package.json
// @symlink: /src/node_modules/lib/package.json
{ "name": "lib", "types": "index.ts" }

// @filename: /src/lib/index.ts
// @symlink: /src/node_modules/lib/index.ts
export { util } from "./util";

// @filename: /src/lib/util.ts
// @symlink: /src/node_modules/lib/util.ts
export const util = 1;
Loading