Repository navigation
Expose some type checker features that were available in TS6 - #64535
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 8 commits into
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 8 commits into
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 8 commits into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Copilot started reviewing on behalf of
Titian Cernicova-Dragomir (dragomirtitian)
September 29, 2026 16:23
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Zero-valued formatting arguments are misinterpreted, escaped-name typing is widened, and unique-symbol behavior lacks regression coverage.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Exposes additional TypeScript 6 checker capabilities through the async and sync APIs.
Changes:
- Adds union-origin, conditional-inference, unique-symbol, and symbol-formatting APIs.
- Adds protocol support and
SymbolFormatFlags. - Adds API and parity tests.
| File | Description |
|---|---|
tsc/internal/checker/types.go |
Exposes checker type metadata. |
tsc/internal/api/session.go |
Handles new API requests. |
tsc/internal/api/proto.go |
Defines protocol methods and payloads. |
tsc/internal/api/enum_values_generated.go |
Registers symbol-format enum values. |
tools/scripts/tsc/generate-enums.ts |
Adds enum generation configuration. |
packages/typescript/test/sync/api.test.ts |
Adds generated sync API tests. |
packages/typescript/test/sync/api-generators.test.ts |
Adds batching parity coverage. |
packages/typescript/test/async/api.test.ts |
Adds async API tests. |
packages/typescript/src/enums/symbolFormatFlags.ts |
Adds runtime enum output. |
packages/typescript/src/enums/symbolFormatFlags.enum.ts |
Adds typed enum output. |
packages/typescript/src/api/sync/types.ts |
Adds generated sync declarations. |
packages/typescript/src/api/sync/api.ts |
Adds generated sync implementations. |
packages/typescript/src/api/proto.generated.ts |
Adds generated protocol declarations. |
packages/typescript/src/api/async/types.ts |
Adds async public type declarations. |
packages/typescript/src/api/async/api.ts |
Implements the async APIs. |
Files not reviewed (1)
- tsc/internal/api/enum_values_generated.go: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1746
to
+1747
| Meaning uint32 `json:"meaning,omitempty"` | ||
| Flags int32 `json:"flags,omitempty"` |
Comment on lines
+3554
to
+3556
| isUniqueESSymbolType(): this is UniqueESSymbolType { | ||
| return isUniqueESSymbolType(this); | ||
| } |
typescript-automation
Bot
added
For Milestone Bug
…eatures # Conflicts: # packages/typescript/src/api/async/api.ts # packages/typescript/src/api/sync/api.ts # packages/typescript/test/async/api.test.ts # packages/typescript/test/sync/api-generators.test.ts # packages/typescript/test/sync/api.test.ts
- Type UniqueESSymbolType.escapedName as __String. - Preserve an explicit SymbolFormatFlags.None in symbolToString; only omitted flags default to AllowAnyNodeKind. Pass meaning through unchanged so an omitted meaning behaves like SymbolFlags.None, as in Strada. - Add regression tests for explicit None flags, omitted meaning, and unique symbol escaped names. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-language integration needs human validation, and unique-symbol name serialization still requires correction.
3 open findings
1 resolved since last review
Files not reviewed (1)
- tsc/internal/api/enum_values_generated.go: Generated file
🧠 Review effort: Balanced
A unique symbol declared by a late-bound member embeds that member's internal name, so escape every "\xFE" marker rather than only the leading one in both UniqueESSymbolType.escapedName and Symbol.escapedName. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
No blocking defects were identified, but cross-language API and generated-client validation remains unverified.
2 open issues
1 resolved since last review
1 file not reviewed
tsc/internal/api/enum_values_generated.go: Generated file
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64533