Skip to content

Fix GCC -Wpedantic and -Wunused-but-set-variable warnings #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chuck Walbourn (walbourn) merged 2 commits into from
Oct 1, 2026
Merged

Fix GCC -Wpedantic and -Wunused-but-set-variable warnings #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae3f80
Fix GCC -Wpedantic and -Wunused-but-set-variable warnings
Kiptoo-Deus Sep 26, 2026
09fc38d
Use #elif defined(__GNUC__) for the GCC diagnostic blocks
Kiptoo-Deus Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Inc/DirectXMath.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,15 @@ namespace DirectX
// Fix-up for (2nd+) XMMATRIX parameters to pass by reference
typedef const XMMATRIX& CXMMATRIX;

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wgnu-anonymous-struct"
#pragma clang diagnostic ignored "-Wnested-anon-types"
#elif defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
Comment thread
walbourn marked this conversation as resolved.
#endif

#ifdef _XM_NO_INTRINSICS_
struct XMMATRIX
#else
Expand Down Expand Up @@ -713,6 +722,12 @@ namespace DirectX
friend XMMATRIX XM_CALLCONV operator*(float S, FXMMATRIX M) noexcept;
};

#ifdef __clang__
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

//------------------------------------------------------------------------------
// 2D Vector; 32 bit floating point components
struct XMFLOAT2
Expand Down Expand Up @@ -1031,6 +1046,9 @@ namespace DirectX
#pragma clang diagnostic ignored "-Wnested-anon-types"
#pragma clang diagnostic ignored "-Wunknown-warning-option"
#pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
#elif defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
#endif

//------------------------------------------------------------------------------
Expand Down Expand Up @@ -1412,6 +1430,8 @@ namespace DirectX

#ifdef __clang__
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif
#ifdef _PREFAST_
#pragma prefast(pop)
Expand Down
2 changes: 2 additions & 0 deletions Inc/DirectXMathMatrix.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,6 +1137,8 @@ _Use_decl_annotations_ inline bool
fAbsZ = fabsf(XMVectorGetZ(ppvBasis[a][0]));

XM3RANKDECOMPOSE(aa, bb, cc, fAbsX, fAbsY, fAbsZ)
(void)aa;
(void)bb;

ppvBasis[b][0] = XMVector3Cross(ppvBasis[a][0], pvCanonicalBasis[cc][0]);
}
Expand Down
5 changes: 5 additions & 0 deletions Inc/DirectXPackedVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ namespace DirectX
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wgnu-anonymous-struct"
#pragma clang diagnostic ignored "-Wnested-anon-types"
#elif defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"
#endif

//------------------------------------------------------------------------------
Expand Down Expand Up @@ -1400,6 +1403,8 @@ namespace DirectX

#ifdef __clang__
#pragma clang diagnostic pop
#elif defined(__GNUC__)
#pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
#pragma warning(pop)
Expand Down
Loading