Conversation
Add support for multiline comments and string as well as fix the old single line comments and strings.
Update nim.yaml to nim 2.0+
Andriamanitra
suggested changes
Sep 21, 2026
Andriamanitra
left a comment
Andriamanitra
left a comment
Collaborator
There was a problem hiding this comment.
I think it would be nice touch to add raw string literals too while we are at it.
|
|
||
| - constant.string: | ||
| start: "\"\"\"" | ||
| end: "\"\"\"" |
Collaborator
There was a problem hiding this comment.
This doesn't seem to be quite right.
The ending of the string literal is defined by the pattern
"""[^"], so this:
""""long string within quotes""""
Produces:
"long string within quotes"
https://nim-lang.org/docs/manual.html#lexical-analysis-triple-quoted-string-literals
Comment on lines
+28
to
+33
| - constant.string: | ||
| start: "'" | ||
| end: "'" | ||
| skip: "\\\\." | ||
| rules: | ||
| - constant.specialChar: "\\\\([\"'abceflnprtv\\\\]|\\d+|x[0-9A-Fa-f]{2}|u[0-9A-Fa-f]{4}|u\\{[0-9A-Fa-f]+\\})" |
Collaborator
There was a problem hiding this comment.
According to the docs single quotes are used for char literals (max 1 byte), not strings.
https://nim-lang.org/docs/manual.html#lexical-analysis-character-literals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for multi-line comments/strings, and fix some mistakes for the single line comments/string. (eg.
"#"was considered a comment and not a string which contains a#)I borrowed some of the logic from the C syntax.