Repository navigation
Sync ako/mxcli: escape '/' inside folder names in FOLDER paths - #1371
Merged
Merged
Conversation
Studio Pro allows '/' in a folder name, but BuildFolderPath joined names with a bare '/' and every folder-path walker split on it. A constant in `Private - String en/de-cryption` > `Apis` was described as folder 'Private - String en/de-cryption/Apis', and replaying the --save-edits output with exec filed it three folders deep, exit 0. New package mdl/folderpath: a '/' in a segment is written `\/`, a '\' `\\`; Split is lenient (a backslash before anything else stays literal), so existing paths keep their meaning. BuildFolderPath joins with it, resolveFolder / findFolderByPath / lookupFolder / the page builder and the project tree split with it. Describers that wrote `folder '%s'` unquoted now use mdlQuote, so the escape (and apostrophes) survive both string rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cj4DQ8PRitHdtF3q8pVVBQ
Fix folder path escaping for names containing slashes
AI Code ReviewCritical IssuesNone found. Moderate IssuesNone found. Minor IssuesNone found. What Looks Good
RecommendationApprove the PR. The changes are correct, well-tested, and maintain consistency with the project's architecture and conventions. The fix resolves the reported issue without introducing regressions. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
ako/mxcli:mainintomendixlabs/mxcli:main: 1 commit since #1366, landed in the fork through ako#1084.Folders
/inside a folder name is escaped in FOLDER paths (marketplace update --save-edits + exec corrupts constant folder paths containing a literal '/' in the folder name #1367). Studio Pro allows/in a folder name, but folder paths were joined and split on a bare/. A constant inPrivate - String en/de-cryption>Apiswas described as folder'Private - String en/de-cryption/Apis', and replaying the describe output filed it three folders deep, with exit 0.mdl/folderpathwrites a/in a segment as\/and a\as\\. Splitting is lenient (a backslash before anything else stays literal), so existing paths keep their meaning.BuildFolderPath, the folder resolvers, the page builder and the project tree all use it. Describers that wrotefolder '%s'unquoted now quote it, so the escape and apostrophes both survive