Skip to content

[MOO-2434]: Rewrite progress bar and progress circle - #670

Open
SrirangK wants to merge 8 commits into
mx/11.12.xfrom
moo/MOO-2434/rewrite-progress-bar-and-circle-11.12
Open

SrirangK wants to merge 8 commits into
mx/11.12.xfrom
moo/MOO-2434/rewrite-progress-bar-and-circle-11.12

Conversation

@SrirangK

@SrirangK SrirangK commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Contains unit tests ✅ ❌
  • Contains breaking changes ✅ ❌
  • Compatible with: MX 8, 9, 10
  • Did you update version and changelog? ✅ ❌
  • PR title properly formatted ([XX-000]: description)? ✅ ❌
  • Works in Android ✅ ❌
  • Works in iOS ✅ ❌
  • Works in Tablet ✅ ❌

Feature specific

  • Comply with designs ✅ ❌
  • Comply with PM's requirements ✅ ❌

Please remove unnecessary emojis and sections and this comment before proceeding

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

...

Relevant changes

Please add a high level explanation of what was changed and how the initial problem was solved

What should be covered while testing?

...

Extra comments (optional)

Please add extra comments or delete the section if not required

@SrirangK
SrirangK requested a review from a team as a code owner October 7, 2026 11:05
@@ -0,0 +1,110 @@
import { JSX } from "react";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is exclusive to Progress Circle so it can be moved there.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the story mentions that these are to be reused for chart rewrite needs later. That is why they are written in the piw-native-utils-internal.

@@ -0,0 +1,88 @@
import { JSX, useState } from "react";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too can be moved to the progress-bar-native folder.

@SrirangK
SrirangK force-pushed the moo/MOO-2434/rewrite-progress-bar-and-circle-11.12 branch from 9656d42 to 2ffa7b2 Compare October 9, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants