Repository navigation
fix(base32): accept lower case ULID strings when decoding - #67
Merged
Merged
Conversation
The ULID spec and the README describe the string representation as case insensitive, and the DECODE table maps lower case letters, but the alphabet check added in 2.6.0 only allowed upper case characters. Check against both cases so ULID.from_str accepts lower case input again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 4 4
Lines 371 372 +1
Branches 61 61
=======================================
+ Hits 366 367 +1
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ULID spec and the README describe the string representation as case insensitive, and the DECODE table maps lower case letters, but the alphabet check added in 2.6.0 only allowed upper case characters. Check against both cases so ULID.from_str accepts lower case input again.