Repository navigation
A plugin hands a dependency on with reexport = true on its [dependencies] edge (#797) - #800
Merged
Merged
Conversation
…ies] edge (#797) The build programs' graph compiles a plugin's [dependencies] with it, and the import check offered `reexport = true` as the way to make such a dependency importable by the plugin's consumers' build programs -- but read reexport only on [build-dependencies] edges, so the advice did not work. A [dependencies] edge with reexport = true hands the library on; without it the import stays refused (e2e 910 G). docs/31 states it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the ecosystem review of #798, before the 2026.10.11.1 tag. The release run is cancelled and will be restarted after this PR.
Defect. A build plugin's
[dependencies]are compiled with it in the build programs' graph. When a consumer'sbuild.mcppimports such a dependency directly, the import check refuses it and says to hand it on withreexport = true. The check, however, readreexportonly on[build-dependencies]edges, so following that advice still failed.Fix.
[dependencies]edge withreexport = truehands the library on to the programs that use the plugin.reexport, the import stays refused, as before and as e2e 311 pins.This is the shape mcpp-index's
docs/package-types.mddocuments for third-party plugins built onmcpp.plugins(plugins-corewithreexport = true), moved to[dependencies].Tests. e2e 910 G covers both cases; 311 and 193 are unchanged and pass locally.
Docs. docs/31 (en, zh).