Repository navigation
release canaries: a project's commands do not see XLINGS_BIN - #799
Merged
Merged
Conversation
The canary job exported XLINGS_BIN, the released xlings that bootstraps mcpp, to every command of the project. xlings' test kit reads the name as the binary under test, so its tests drove the released xlings instead of the one they had just built. With xlings 2026.10.11.2, test_subos_new_template read an instance.json the released xlings does not write, and the canary blocked the 2026.10.11.1 tag. mcpp keeps its xlings through MCPP_VENDORED_XLINGS; the project's commands run without XLINGS_BIN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xlings canary blocked the 2026.10.11.1 release.
Cause. The canary job exports
XLINGS_BIN, the released xlings that bootstraps mcpp, to every command of the project. xlings' test kit (modules/testkit,xlings_binary()) reads that name as the binary under test. Its tests therefore drove the released xlings 2026.10.10.2 instead of the xlings they had just built (main, 2026.10.11.2).Effect.
test_subos_new_templatereadseditionfrominstance.json. The released xlings does not write that field, so the test failed withAssertion it != end().Reproduced locally:
XLINGS_BIN, the same assertion fires.XLINGS_BIN, the test passes.The same result with the candidate mcpp and with the released one: the cause is not mcpp.
Fix. mcpp keeps its xlings through
MCPP_VENDORED_XLINGS, and the project's commands run withoutXLINGS_BIN.Control. The canary at the 2026.10.10.2 tag (the released mcpp) fails the same test the same way (run 38106327920). The cause is the canary environment, not the candidate mcpp.