Skip to content

ReportHeader - update UI screenshots (feature branch) - #95

Merged
AltamashShaikh merged 14 commits into
6.x-devfrom
feature-new-report-header
Sep 29, 2026
Merged

AltamashShaikh merged 14 commits into
6.x-devfrom
feature-new-report-header

Conversation

@tzi

@tzi tzi commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Feature branch for the report header work in this plugin: it carries the 3 expected UI screenshots regenerated for the DataTable search moving from the table footer into the shared report header.

Merged into this branch

Impact

None visible to users: expected test screenshots only.

Step by step tests

Nothing to exercise by hand. The screenshots come from the CI artifacts of matomo-org/matomo#24986 and are verified by the core feature branch, matomo-org/matomo#25059.

Note on the UI tests

The plugin's own UI jobs run against core 6.x-dev, which does not yet contain the report header change, so they compare these screenshots against a core that renders the old footer search and go red. They turn green once matomo-org/matomo#25059 lands. Merge this only together with that PR.

Checklist

  • [NA] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

tzi added 12 commits September 21, 2026 02:18
The DataTable search moved from the table footer into the shared ReportHeader
(matomo-org/matomo#24986), which changes every report screenshot.
Taken from the core branch that moves the report actions behind the header's 3-dots
trigger, rebuilt on the pin core's base branch now records so the images carry that
base's rendering rather than the one the earlier branch was generated against.
The title and the controls beside it line up on their centres, and the two control clusters keep
8px apart. Every report keeps its size.
The report header lifts Export out of its 3-dots menu into a control of its own, so the line above
every full-page report in this plugin changed with it.
The control at the foot of a report takes the shape of the report's other controls, and on a table
it moves onto the pagination line.
The control is centred by the pagination line itself now, rather than by a transform that opened a
stacking context around it.
It sat flush against the card and now keeps 20px from its right and bottom edges.
A variable name shared with the header's selector had been widening every one of them; these were
captured while it did.
Taken from the core CI run for feature-new-report-header, which changes the
report header, the pagination row and the pagination counter.
@tzi
tzi force-pushed the feature-new-report-header branch from b9f61ca to 71cf61b Compare September 21, 2026 00:20
tzi added 2 commits September 23, 2026 02:17
The report actions moved back into the 3-dots menu for a Widgetize embed, so the
promoted Export button is gone from the header line and the panel is 10px shorter.
@tzi
tzi marked this pull request as ready for review September 29, 2026 00:38
@tzi
tzi requested a review from a team September 29, 2026 06:13
@AltamashShaikh

Copy link
Copy Markdown
Contributor

@tzi Can you update the PR description with the required template code ?

@tzi

tzi commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@AltamashShaikh: Can you update the PR description with the required template code ?

I updated the checklist. Is it OK?

@AltamashShaikh
AltamashShaikh merged commit 7eb9e6d into 6.x-dev Sep 29, 2026
76 of 91 checks passed
@AltamashShaikh

Copy link
Copy Markdown
Contributor

@tzi The AI one is the most important as it is needed as per privacy officer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants