Repository navigation
Conversation
mathiasrw
marked this pull request as draft
October 23, 2026 11:30
mathiasrw
marked this pull request as ready for review
October 23, 2026 12:02
mathiasrw
marked this pull request as draft
October 23, 2026 14:32
…t can not be read
mathiasrw
marked this pull request as ready for review
October 23, 2026 14:34
mathiasrw
marked this pull request as draft
October 23, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #788
The first PR of a new train. #789 and #790 go on top of it.
Change
fs.statSyncthrew everything but ENOENT, and the run crashed with a stack trace. Now:0 files found.a.md/x, wherea.mdis a file), it is an error (exit code 2), and the run goes on with the files that can be found:--glob-pipe. A glob of--exclude-globthat fails is a panic (exit code 3), as the files it should keep out can not be known.With Bun and Node the long brace glob from the issue now just works: the files it can find are found.
From the review of 23 October.
Tests
yarn test-cipasses: the demo on Node and Bun, and 1028 Bun tests.test/fix/788.test.jsis new, and all its tests fail without the fix.After the review of 24 October
Not all paths could be accessed: EACCES …), and the run goes on with the files that can be found. The exit code is 2, like for a file that can not be read. Before, one locked folder anywhere in'**/*.md'stopped the whole run, and no file was changed.--haltit still stops at once.--exclude-globthat fails is still a panic, as the files it should keep out can not be known, and they must not be changed.After the review of 24 October
Not all paths could be accessed: EACCES ….