Repository navigation
P0 Studio UX: authoritative 4I+4V START, compact vertical layout and readable controls #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
masarray
wants to merge
18
commits into
feature/studio-matched-ptp-sv-auto-20261017
Choose a base branch
from
fix/studio-signal-ssot-ui-polish-20261018
base: feature/studio-matched-ptp-sv-auto-20261017
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4834a19
fix(studio): every START sends current 4I+4V table instead of reusing…
masarray 29e53db
style(studio): stack voltage over current for full-width control and …
masarray 7045de2
style(studio): restore normal 40px injector brand mark and legible ri…
masarray c727058
style(studio): readable near-white hover with dark text and matching …
masarray d49127e
style(studio): single consistent custom checkbox geometry across hove…
masarray 517cbe1
style(studio): center ribbon icons and captions both horizontally and…
masarray 56b2dd3
feat(studio): default verified device to PTP SOURCE ON with AUTO sync…
masarray 63658b8
style(studio): Advanced tabs readable white hover/dark captions and t…
masarray dd78fed
test(studio): freeze SSOT START, local-sync baseline and normalized o…
masarray e8fc839
test(studio): accept multiline SSOT START snapshot command formatting
masarray 047e5a7
style(studio): Advanced selectors use high-contrast white hover and d…
masarray 2c3a223
test(studio): recognize multiline full table START without requiring …
masarray e0b98ee
fix(studio): reserve full 4-row intrinsic height for each stacked tab…
masarray 3ce4bea
test(studio): assert non-clipping vertical matrix height
masarray c5d886c
fix(studio): responsive vertical Voltage/Current with compact short-w…
masarray 2356e37
test(studio): assert stacked full-size or compact fallback geometry w…
masarray 988faf6
test(studio): protect vertical normal-height and compact short-height…
masarray 679da6c
build(studio): include cmath explicitly for viewport alignment tolerance
masarray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this timer auto-starts a stopped board,
root.startPtpRole()recordsptpDesiredForSession = true; however, the Advanced PTP switch stops directly throughpanel.session.requestStopPtp()inPtpExpertPanel.qml:137and never clears that intent. After an explicit OFF through that switch, any successful firmware update therefore enters the restoration path atMain.qml:212-214and turns SOURCE back on, unexpectedly resuming network transmission. Keep automatic/default state separate from explicit restore intent, or route every OFF control through the intent owner.AGENTS.md reference: AGENTS.md:L74-L76
Useful? React with 👍 / 👎.